Skip to content
This repository was archived by the owner on Nov 4, 2024. It is now read-only.

Commit 9a00cdd

Browse files
committed
0.12.7 - Fix version comparator AGAIN
1 parent 31d311c commit 9a00cdd

File tree

7 files changed

+11
-14
lines changed

7 files changed

+11
-14
lines changed

SaneEconomyCore/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
<version>0</version>
1010
</parent>
1111
<artifactId>SaneEconomyCore</artifactId>
12-
<version>0.12.6-SNAPSHOT</version>
12+
<version>0.12.7-SNAPSHOT</version>
1313

1414
<dependencies>
1515
<dependency>

SaneEconomyCore/src/main/java/org/appledash/saneeconomy/updates/VersionComparer.java

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -17,20 +17,16 @@ public static boolean isSemVerGreaterThan(String first, String second) {
1717
int[] firstParts = intifyParts(first);
1818
int[] secondParts = intifyParts(second);
1919

20-
if (secondParts[0] > firstParts[0]) {
21-
return true;
22-
}
23-
24-
if (secondParts[1] > firstParts[1]) {
25-
return true;
26-
}
27-
28-
return secondParts[2] > firstParts[2];
20+
return computeInt(secondParts) > computeInt(firstParts);
2921
}
3022

3123
private static int[] intifyParts(String version) {
3224
String[] firstParts = version.split("\\.");
3325

3426
return new int[] { Integer.valueOf(firstParts[0]), Integer.valueOf(firstParts[1]), Integer.valueOf(firstParts[2]) };
3527
}
28+
29+
private static int computeInt(int[] parts) {
30+
return (parts[0] * 1000000) + (parts[1] * 1000) + parts[2];
31+
}
3632
}

SaneEconomyCore/src/main/resources/plugin.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
name: SaneEconomy
22
author: AppleDash
33
main: org.appledash.saneeconomy.SaneEconomy
4-
version: 0.12.6
4+
version: 0.12.7
55
load: STARTUP
66
softdepend: [Vault]
77
commands:

SaneEconomyCore/src/test/java/org/appledash/saneeconomy/test/VersionComparerTest.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,5 +15,6 @@ public void testVersionComparer() {
1515
Assert.assertFalse(VersionComparer.isSemVerGreaterThan("2.0.0", "1.0.0"));
1616
Assert.assertTrue(VersionComparer.isSemVerGreaterThan("0.1.0", "0.2.0"));
1717
Assert.assertTrue(VersionComparer.isSemVerGreaterThan("1.0.0", "2.0.0"));
18+
Assert.assertFalse(VersionComparer.isSemVerGreaterThan("0.12.6", "0.5.7"));
1819
}
1920
}

SaneEconomyMobKills/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
<dependency>
1717
<groupId>org.appledash</groupId>
1818
<artifactId>SaneEconomyCore</artifactId>
19-
<version>0.12.6-SNAPSHOT</version>
19+
<version>0.12.7-SNAPSHOT</version>
2020
</dependency>
2121
</dependencies>
2222

SaneEconomyOnlineTime/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
<dependency>
1818
<groupId>org.appledash</groupId>
1919
<artifactId>SaneEconomyCore</artifactId>
20-
<version>0.12.6-SNAPSHOT</version>
20+
<version>0.12.7-SNAPSHOT</version>
2121
</dependency>
2222
</dependencies>
2323

SaneEconomySignShop/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
<dependency>
1717
<groupId>org.appledash</groupId>
1818
<artifactId>SaneEconomyCore</artifactId>
19-
<version>0.12.6-SNAPSHOT</version>
19+
<version>0.12.7-SNAPSHOT</version>
2020
</dependency>
2121
</dependencies>
2222

0 commit comments

Comments
 (0)