Skip to content

Conversation

@nguyenluan3017
Copy link
Contributor

Test Case File Pattern Component Expected Result Actual Result Issue Description
1 GenericPrometheusQuery_testgroup_metricname_data.json Measurement metricname '' (empty string) The get_measurement method is not correctly extracting the metric name from GenericPrometheusQuery files. It should extract metricname from the filename pattern but returns empty string instead.
2 PodStartupLatency_PodStartupLatency_.json Group Name '' (empty string) .json The method is incorrectly parsing the group name when there's an empty group section (underscore followed by file extension). It should return empty string but returns .json instead.
3 APIResponsivenessPrometheus_.json Group Name '' (empty string) .json Similar to case 2, the method fails to handle empty group names correctly and returns the file extension instead of an empty string.

@sumanthreddy29
Copy link
Collaborator

@nguyenluan3017 , can you resolve merge conflicts? Pull latest changes and fix CI checks

@nguyenluan3017 nguyenluan3017 changed the title Unit Test Refactored Large Module and Clusterloader2Base classes [DRAFT] Unit Test Refactored Large Module and Clusterloader2Base classes Sep 25, 2025
@nguyenluan3017
Copy link
Contributor Author

@nguyenluan3017 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree company="Microsoft"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants