Skip to content

Conversation

@vittoriasalim
Copy link
Contributor

as title

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds Azure Firewall support to the Terraform Azure modules, enabling users to configure firewalls with NAT, network, and application rule collections. The implementation includes a new firewall submodule with comprehensive rule configuration options and proper integration with the existing network module infrastructure.

Key Changes

  • Added new firewall submodule under modules/terraform/azure/network/firewall/ with support for NAT, network, and application rule collections
  • Extended variable definitions at both the top-level (modules/terraform/azure/variables.tf) and network module (modules/terraform/azure/network/variables.tf) to include firewall configuration
  • Added public IP address output to support firewall IP tracking

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
modules/terraform/azure/variables.tf Added firewall configuration object to network_config_list with support for SKU, DNS, and rule collections
modules/terraform/azure/public-ip/output.tf Added pip_addresses output to map public IP names to their addresses
modules/terraform/azure/network/variables.tf Added firewall configuration to network_config with inline comments documenting valid values
modules/terraform/azure/network/output.tf Added firewalls output to expose private IP addresses of deployed firewalls
modules/terraform/azure/network/main.tf Integrated firewall module with for_each loop over firewall configurations
modules/terraform/azure/network/firewall/variables.tf Defined firewall_config variable with comprehensive rule collection schemas
modules/terraform/azure/network/firewall/output.tf Defined private_ip_address output for firewall instances
modules/terraform/azure/network/firewall/main.tf Implemented azurerm_firewall resource with NAT, network, and application rule collections
modules/terraform/azure/network/firewall/README.md Added documentation for the firewall module with usage examples

@vittoriasalim vittoriasalim force-pushed the vitto/firewalls_feat branch 2 times, most recently from daa33f2 to df33e96 Compare December 4, 2025 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants