-
Notifications
You must be signed in to change notification settings - Fork 18
feat(firewall) : add firewall feature to support route table egress + to enable udr #947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds Azure Firewall support to the Terraform Azure modules, enabling users to configure firewalls with NAT, network, and application rule collections. The implementation includes a new firewall submodule with comprehensive rule configuration options and proper integration with the existing network module infrastructure.
Key Changes
- Added new firewall submodule under
modules/terraform/azure/network/firewall/with support for NAT, network, and application rule collections - Extended variable definitions at both the top-level (
modules/terraform/azure/variables.tf) and network module (modules/terraform/azure/network/variables.tf) to include firewall configuration - Added public IP address output to support firewall IP tracking
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| modules/terraform/azure/variables.tf | Added firewall configuration object to network_config_list with support for SKU, DNS, and rule collections |
| modules/terraform/azure/public-ip/output.tf | Added pip_addresses output to map public IP names to their addresses |
| modules/terraform/azure/network/variables.tf | Added firewall configuration to network_config with inline comments documenting valid values |
| modules/terraform/azure/network/output.tf | Added firewalls output to expose private IP addresses of deployed firewalls |
| modules/terraform/azure/network/main.tf | Integrated firewall module with for_each loop over firewall configurations |
| modules/terraform/azure/network/firewall/variables.tf | Defined firewall_config variable with comprehensive rule collection schemas |
| modules/terraform/azure/network/firewall/output.tf | Defined private_ip_address output for firewall instances |
| modules/terraform/azure/network/firewall/main.tf | Implemented azurerm_firewall resource with NAT, network, and application rule collections |
| modules/terraform/azure/network/firewall/README.md | Added documentation for the firewall module with usage examples |
daa33f2 to
df33e96
Compare
as title