Skip to content

Conversation

@David-GERARD
Copy link
Contributor

Description

Changing the version to 1.25.1 for future release. This is required for pypi to display the right version after publishing a release on GitHub and execution of the build-publish workflow.

Type of change

  • New feature (non-breaking change which adds functionality)

@David-GERARD David-GERARD added the enhancement New feature or request label Apr 22, 2025
@David-GERARD David-GERARD requested a review from yjhan96 April 22, 2025 16:04
@David-GERARD
Copy link
Contributor Author

@yjhan96 this is important as I hadn't done it previously leading to pypi displaying the wrong release tag (1.24.4 instead of 1.25.0), so for future releases we must make sure to check that the pettingzoo/init.py has been updated. Same goes for SuperSuit.

@yjhan96
Copy link
Collaborator

yjhan96 commented Apr 27, 2025

It looks like SB3/waterworld tutorial test is failing due to a SuperSuit-related error. Once we fix that, this should be good to merge.

@dm-ackerman
Copy link
Contributor

I think I fixed the waterworld test issue with a PR in the supersuit repo

@yjhan96 or @David-GERARD can you check the supersuit PR and merge if it looks good?

Hopefully that will fix the issue with this PR and #1297

@yjhan96
Copy link
Collaborator

yjhan96 commented May 8, 2025

Hi @dm-ackerman - I approved the PR you made in SuperSuit. Once that's merged, we can fix this PR's issue, too.

@David-GERARD David-GERARD added this to the 1.25.1 milestone May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants