Skip to content

Commit a5b6b23

Browse files
committed
fix: document describe cluster gaps and sasl casing
1 parent 226a36a commit a5b6b23

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

admin.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -376,6 +376,10 @@ func (ca *clusterAdmin) describeClusterUsingMetadata() (brokers []*Broker, contr
376376
}
377377

378378
func convertDescribeClusterBrokers(entries []*DescribeClusterBroker) []*Broker {
379+
// TODO: DescribeCluster brokers currently drop DescribeCluster-specific fields
380+
// such as IsFenced (KIP-1073) and ClusterAuthorizedOperations because Broker
381+
// has no equivalents yet. This keeps API parity with MetadataResponse for now,
382+
// but the richer fields need to be surfaced in a future change.
379383
if len(entries) == 0 {
380384
return nil
381385
}

examples/describe_cluster/main.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ func configureSASL(config *sarama.Config) error {
122122
config.Net.SASL.AuthIdentity = *saslAuthzID
123123

124124
switch mech {
125-
case "PLAIN", "PLAINtext":
125+
case "PLAIN", "PLAINTEXT":
126126
config.Net.SASL.Mechanism = sarama.SASLTypePlaintext
127127
case "SCRAM-SHA-256":
128128
config.Net.SASL.Mechanism = sarama.SASLTypeSCRAMSHA256

0 commit comments

Comments
 (0)