Skip to content

Conversation

@evgeni
Copy link
Member

@evgeni evgeni commented Oct 30, 2025

Implements https://community.theforeman.org/t/rfc-packit-based-nightlies-for-everyone/44268

What are the changes introduced in this pull request?

Considerations taken when implementing this change?

What are the testing steps for this pull request?

Summary by Sourcery

Add a commit-triggered Copr build job to .packit.yaml by reusing the Pull Request job configuration through a YAML anchor

New Features:

  • Add a Packit copr_build job triggered on commits to the master branch for theforeman/develop repository

Enhancements:

  • Refactor the existing copr_build job into a reusable YAML anchor to avoid duplication

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes - here's some feedback:

  • Verify that owner: '@theforeman' and project: develop actually correspond to the target repository, since develop looks more like a branch name than a project.
  • Consider adding branch or path filters to the commit-triggered job so that nightly COPR builds only run on relevant changes and don’t trigger on every commit.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Verify that `owner: '@theforeman'` and `project: develop` actually correspond to the target repository, since `develop` looks more like a branch name than a project.
- Consider adding branch or path filters to the commit-triggered job so that nightly COPR builds only run on relevant changes and don’t trigger on every commit.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant