Skip to content

Fix edge case of effects without facets not running #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pirelenito merged 2 commits into from
Nov 12, 2025
Merged

Fix edge case of effects without facets not running #165

pirelenito merged 2 commits into from
Nov 12, 2025

Conversation

@pirelenito
Copy link
Member

@pirelenito pirelenito commented Nov 12, 2025

Fix this edge-case:

useFacetEffect(
  () => {
    console.log('should run, but currently does not')
  },
  [],
  [],
)

@pirelenito pirelenito enabled auto-merge (squash) November 12, 2025 14:54
@pirelenito pirelenito merged commit a8dc039 into main Nov 12, 2025
12 checks passed
@pirelenito pirelenito deleted the effects-without-facets branch November 12, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marlonicus marlonicus marlonicus approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pirelenito @marlonicus