-
Notifications
You must be signed in to change notification settings - Fork 600
feat(integrations): add support for totango #4913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
hassan254-prog
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution. I’ve added a few comments inline, could you also include the logo and add the docs link here. Also noticed that some of the provider's links are broken.
packages/providers/providers.yaml
Outdated
| title: App Token | ||
| description: The App Token for your Totango account | ||
| doc_section: '#instructions' | ||
| example: 9164000970ca2f15c999047a0e2b7e03127885be41198616a6975af08b28239b |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice to also include the pattern.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'm not actually sure of the pattern since i don't see on totango's docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They’re usually not documented in the provider’s docs. I’d recommend generating a few sample tokens first, then determining the regex pattern based on them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unfortunately don't myself have an account for that
Co-authored-by: Hassan_Wari <[email protected]>
Co-authored-by: Hassan_Wari <[email protected]>
| Next step: [Embed the auth flow](/getting-started/quickstart/embed-in-your-app) in your app to let your users connect their Totango accounts. | ||
| </Tip> | ||
| </Tab> | ||
| </Tab> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Documentation]
Remove the extra closing </Tab> tag—there are two consecutive </Tab> tags, which leaves the <Tabs> block unbalanced.
Context for Agents
[**Documentation**]
Remove the extra closing `</Tab>` tag—there are two consecutive `</Tab>` tags, which leaves the `<Tabs>` block unbalanced.
File: docs/integrations/all/totango.mdx
Line: 66| title: App Token | ||
| description: The App Token for your Totango account | ||
| doc_section: '#step-1-finding-your-app-token' | ||
| example: '9164000970ca2f15c999047a0e2b7e03127885be41198616a6975af08b28239b' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[CriticalError]
API Token example appears to be a real token
The example API token 9164000970ca2f15c999047a0e2b7e03127885be41198616a6975af08b28239b looks like a valid 64-character hex string, which might be an actual token.
Security: Verify this is a dummy value, not a real API token. If there's any chance this is real, rotate it immediately and replace with an obviously fake example like:
example: 'xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx'
or
example: '0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef'
Context for Agents
**API Token example appears to be a real token**
The example API token `9164000970ca2f15c999047a0e2b7e03127885be41198616a6975af08b28239b` looks like a valid 64-character hex string, which might be an actual token.
**Security**: Verify this is a dummy value, not a real API token. If there's any chance this is real, rotate it immediately and replace with an obviously fake example like:
```
example: 'xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx'
```
or
```
example: '0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef'
```
File: packages/providers/providers.yaml
Line: 13537| Once you have your **App Token** and **Service ID**: | ||
| 1. Open the form where you need to authenticate with Totango. | ||
| 2. Enter your **App Token** in the App Token field. | ||
| 3. Enter your **Service ID** (middle number only) in the Service ID field. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Documentation]
Clarify which value should be entered: Step 2 defines the Service ID as SP-234164-01, but Step 3 says to enter the “middle number only.” This inconsistency may confuse users.
Context for Agents
[**Documentation**]
Clarify which value should be entered: Step 2 defines the **Service ID** as `SP-234164-01`, but Step 3 says to enter the “middle number only.” This inconsistency may confuse users.
File: docs/integrations/all/totango/connect.mdx
Line: 49| - ticketing | ||
| auth_mode: OAUTH2 | ||
| authorization_url: https://app.${connectionConfig.region}.intercom.com/oauth || https://app.intercom.com/oauth | ||
| authorization_url: https://app.${connectionConfig.region}.intercom.com || https://app.intercom.com/oauth |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you please revert these breaking changes.
| app-token: ${apiKey} | ||
| connection_config: | ||
| service_id: ${connectionConfig.serviceId} | ||
| verification: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can skip adding the proxy.verification field if you haven't tested this locally.
| title: App Token | ||
| description: The App Token for your Totango account | ||
| doc_section: '#step-1-finding-your-app-token' | ||
| example: '9164000970ca2f15c999047a0e2b7e03127885be41198616a6975af08b28239b' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| example: '9164000970ca2f15c999047a0e2b7e03127885be41198616a6975af08b28239b' | |
| 2. Enter your **App Token** in the App Token field. | ||
| 3. Enter your **Service ID** (middle number only) in the Service ID field. | ||
| 4. Submit the form, and you should be successfully authenticated. | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be helpful to include a screenshot of the nango connect-ui form, along with the provider’s screenshots showing how to generate the token and where to find the service ID.
|
|
||
| - **Expiration Time**: Choose from 7, 30, 60, 90 days, no expiration, or custom. | ||
| 5. Click **Generate Token**. | ||
| 6. Copy the generated token - it will be available to copy and paste directly into the third-party system. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| 6. Copy the generated token - it will be available to copy and paste directly into the third-party system. | |
| 6. Copy your generated token. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This logo should be placed in a 64×64 px container, with a constrained maximum height or width of 44 px.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would also revert these changes.
Describe the problem and your solution
add support for totango
Add Totango Integration: Provider Config, Docs, and Assets
This PR introduces support for the Totango API by adding a new provider configuration, and associated assets. The changes are fully additive and aim to make Totango available as a pre-configured integration within the platform, including authentication, documentation, and branding.
Add First-Class Totango Integration (provider config, docs & branding)
This PR introduces out-of-the-box support for the Totango customer-success platform. It is a purely additive change that registers Totango in the provider catalog, ships setup documentation, and adds official branding assets so users can establish a Totango connection through the UI without manual YAML edits.
Key Changes
• Registered new
totangoprovider in packages/providers/providers.yaml with base URL, default serviceId, and API-Key auth schema• Added end-to-end setup & usage docs (docs/integrations/all/totango*.mdx)
• Included official Totango logo (public/images/template-logos/totango.svg) for marketplace/wizard branding
• Regenerated package-lock.json (no new runtime deps, housekeeping only)
Affected Areas
• Provider registry / connection UI
• Integration documentation site
• Marketplace & connection-wizard branding assets
• package-lock.json
This summary was automatically generated by @propel-code-bot