Skip to content

Types in openzwave-shared.d.ts don't match the test files #368

@rschristian

Description

@rschristian

For example, in test2.js there is the following code:

nodes[nodeid] = {
    manufacturer: '',
    manufacturerid: '',
    product: '',
    producttype: '',
    productid: '',
    type: '',
    name: '',
    loc: '',
    classes: {},
    ready: false,
  };

Only, the type definitions for the library state that these are the correct types:

export interface NodeInfo {
	manufacturer: string;
	manufacturerid: string;
	product: string;
	producttype: string;
	productid: string;
	type: string;
	name: string;
	loc: string;
}

Are classes and ready actually part of the object, or are they unused? Without a solid definition of the types, this library is incredibly difficult to use.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions