caching inside BuildEditorAsync & UpdateEditorAsync is too aggressive

[lampersky]

I have a use case where I need to call UpdateEditorAsync and BuildEditorAsync in a single request. However, when I mutate the content item between the method calls, the returned shape is not what I expected.

pseudo code:

var contentItem = await _contentManager.GetAsync(contentItemId, VersionOptions.DraftRequired);
//update editor
var shape = await _contentItemDisplayManager.UpdateEditorAsync(contentItem, this, false);
// lets change content item a bit, this is just an example, you can change parts depends on used ContentType
contentItem = contentItem.Merge(await _contentManager.NewAsync(contentItem.ContentType),
    new JsonMergeSettings
    {
        MergeArrayHandling = MergeArrayHandling.Replace,
        MergeNullValueHandling = MergeNullValueHandling.Merge,
    }
);
// build editor
shape = await _contentItemDisplayManager.BuildEditorAsync(contentItem, updater: new NullModelUpdater(), false);

return View(nameof(Edit), shape);

I expected the shape produced by BuildEditorAsync, but I'm getting a cached value produced by UpdateEditorAsync instead.

[Piedone]

To confirm: is the shape seemingly the same (i.e. the object in the shape variable, and its properties) or is it the shape rendering, i.e. the HTML output?

Also, which OC version are you using?

[lampersky]

• it is a shape rendering (content item inside shape is mutated as expected) just the html output is the same,
• I've observed this on latest and on a few stable versions.

will check if all ContentItem parts shapes are the same, because I remember that BagPart mutation was reflected properly inside the returned html, leave it for now, will try to find some time to prepare better repro repo

[Piedone]

OK, thank you!