Update OC 1.8.0-preview-17858 to 1.9.x latest

[hyzx86]

My data works fine under version 1.8.0-preview-17858 , but after upgrading to the latest version 1.9x, I have the following problem when I log in. The admin account looks fine, but this exception is also thrown when I open the user list

InvalidOperationException: Each parameter in the deserialization constructor on type 'Microsoft.AspNetCore.Identity.UserLoginInfo' must bind to an object property or field on deserialization. 
Each parameter name must match with a property or field on the object. Fields are only considered when 
'JsonSerializerOptions.IncludeFields' is enabled. The match can be case-insensitive.

User Document

{
    "Id": 2241,
    "UserId": "4fkpnj0fnawmzy3zdc5kx5pnn1",
    "UserName": "xxxx",
    "NormalizedUserName": "xxxxx",
    "Email": "xxx.xx@xxx.com",
    "NormalizedEmail": "xxx.xx@xxx.COM",
    "PasswordHash": "xxxx",
    "SecurityStamp": "xxxx",
    "EmailConfirmed": false,
    "PhoneNumberConfirmed": false,
    "IsEnabled": true,
    "TwoFactorEnabled": false,
    "IsLockoutEnabled": true,
    "AccessFailedCount": 0,
    "RoleNames": [
        "Administrator"
    ],
    "UserClaims": [],
    "LoginInfos": [
        {
            "LoginProvider": "OpenIdConnect",
            "ProviderKey": "xxxx",
            "ProviderDisplayName": "default"
        }
    ],
    "UserTokens": [],
    "Properties": {
    }
}

Details：

System.InvalidOperationException: Each parameter in the deserialization constructor on type 'Microsoft.AspNetCore.Identity.UserLoginInfo' must bind to an object property or field on deserialization. Each parameter name must match with a property or field on the object. Fields are only considered when 'JsonSerializerOptions.IncludeFields' is enabled. The match can be case-insensitive.
   at System.Text.Json.ThrowHelper.ThrowInvalidOperationException_ConstructorParameterIncompleteBinding(Type parentType)
   at System.Text.Json.Serialization.Converters.ObjectWithParameterizedConstructorConverter`1.OnTryRead(Utf8JsonReader& reader, Type typeToConvert, JsonSerializerOptions options, ReadStack& state, T& value)
   at System.Text.Json.Serialization.JsonConverter`1.TryRead(Utf8JsonReader& reader, Type typeToConvert, JsonSerializerOptions options, ReadStack& state, T& value, Boolean& isPopulatedValue)
   at System.Text.Json.Serialization.JsonCollectionConverter`2.OnTryRead(Utf8JsonReader& reader, Type typeToConvert, JsonSerializerOptions options, ReadStack& state, TCollection& value)
   at System.Text.Json.Serialization.JsonConverter`1.TryRead(Utf8JsonReader& reader, Type typeToConvert, JsonSerializerOptions options, ReadStack& state, T& value, Boolean& isPopulatedValue)
   at System.Text.Json.Serialization.Metadata.JsonPropertyInfo`1.ReadJsonAndSetMember(Object obj, ReadStack& state, Utf8JsonReader& reader)
   at System.Text.Json.Serialization.Converters.ObjectDefaultConverter`1.OnTryRead(Utf8JsonReader& reader, Type typeToConvert, JsonSerializerOptions options, ReadStack& state, T& value)
   at System.Text.Json.Serialization.JsonConverter`1.ReadCore(Utf8JsonReader& reader, JsonSerializerOptions options, ReadStack& state)
   at System.Text.Json.Serialization.Metadata.JsonTypeInfo`1.DeserializeAsObject(Utf8JsonReader& reader, ReadStack& state)
   at System.Text.Json.JsonSerializer.ReadFromSpanAsObject(ReadOnlySpan`1 utf8Json, JsonTypeInfo jsonTypeInfo, Nullable`1 actualByteCount)
   at System.Text.Json.JsonSerializer.ReadFromSpanAsObject(ReadOnlySpan`1 json, JsonTypeInfo jsonTypeInfo)
   at System.Text.Json.JsonSerializer.Deserialize(String json, Type returnType, JsonSerializerOptions options)
   at YesSql.Serialization.DefaultJsonContentSerializer.Deserialize(String content, Type type)
   at YesSql.Session.Get[T](IList`1 documents, String collection)
   at YesSql.Services.DefaultQuery.Query`1.FirstOrDefaultImpl()
   at YesSql.Services.DefaultQuery.Query`1.FirstOrDefaultImpl()
   at OrchardCore.Users.Services.UserStore.FindByNameAsync(String normalizedUserName, CancellationToken cancellationToken)
   at Microsoft.AspNetCore.Identity.UserManager`1.FindByNameAsync(String userName)
   at OrchardCore.Users.Services.UserService.GetUserAsync(String userName)
   at OrchardCore.Users.Controllers.AccountController.Login(LoginViewModel model, String returnUrl)
   at Microsoft.AspNetCore.Mvc.Infrastructure.ActionMethodExecutor.TaskOfIActionResultExecutor.Execute(ActionContext actionContext, IActionResultTypeMapper mapper, ObjectMethodExecutor executor, Object controller, Object[] arguments)
   at Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.<InvokeActionMethodAsync>g__Awaited|12_0(ControllerActionInvoker invoker, ValueTask`1 actionResultValueTask)
   at Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.<InvokeNextActionFilterAsync>g__Awaited|10_0(ControllerActionInvoker invoker, Task lastTask, State next, Scope scope, Object state, Boolean isCompleted)
   at Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.Rethrow(ActionExecutedContextSealed context)
   at Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.Next(State& next, Scope& scope, Object& state, Boolean& isCompleted)
   at Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.<InvokeInnerFilterAsync>g__Awaited|13_0(ControllerActionInvoker invoker, Task lastTask, State next, Scope scope, Object state, Boolean isCompleted)
   at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.<InvokeNextExceptionFilterAsync>g__Awaited|26_0(ResourceInvoker invoker, Task lastTask, State next, Scope scope, Object state, Boolean isCompleted)
   at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.Rethrow(ExceptionContextSealed context)
   at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.Next(State& next, Scope& scope, Object& state, Boolean& isCompleted)
   at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.<InvokeNextResourceFilter>g__Awaited|25_0(ResourceInvoker invoker, Task lastTask, State next, Scope scope, Object state, Boolean isCompleted)
   at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.Rethrow(ResourceExecutedContextSealed context)
   at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.Next(State& next, Scope& scope, Object& state, Boolean& isCompleted)
   at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.<InvokeFilterPipelineAsync>g__Awaited|20_0(ResourceInvoker invoker, Task lastTask, State next, Scope scope, Object state, Boolean isCompleted)
   at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.<InvokeAsync>g__Awaited|17_0(ResourceInvoker invoker, Task task, IDisposable scope)
   at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.<InvokeAsync>g__Awaited|17_0(ResourceInvoker invoker, Task task, IDisposable scope)
   at Swashbuckle.AspNetCore.SwaggerUI.SwaggerUIMiddleware.Invoke(HttpContext httpContext)
   at Swashbuckle.AspNetCore.Swagger.SwaggerMiddleware.Invoke(HttpContext httpContext, ISwaggerProvider swaggerProvider)
   at OrchardCore.Apis.GraphQL.GraphQLMiddleware.InvokeAsync(HttpContext context, RequestDelegate next)
   at Microsoft.AspNetCore.Builder.UseMiddlewareExtensions.InterfaceMiddlewareBinder.<>c__DisplayClass2_0.<<CreateMiddleware>b__0>d.MoveNext()
--- End of stack trace from previous location ---
   at SixLabors.ImageSharp.Web.Middleware.ImageSharpMiddleware.Invoke(HttpContext httpContext, Boolean retry)
   at Microsoft.AspNetCore.Authorization.AuthorizationMiddleware.Invoke(HttpContext context)
   at OrchardCore.Liquid.ScriptsMiddleware.Invoke(HttpContext httpContext)
   at Microsoft.AspNetCore.Localization.RequestLocalizationMiddleware.Invoke(HttpContext context)
   at Microsoft.AspNetCore.Authentication.AuthenticationMiddleware.Invoke(HttpContext context)
   at Microsoft.AspNetCore.Routing.EndpointRoutingMiddleware.<Invoke>g__AwaitMatch|10_1(EndpointRoutingMiddleware middleware, HttpContext httpContext, Task matchTask)
   at OrchardCore.Diagnostics.DiagnosticsStartupFilter.<>c__DisplayClass3_0.<<Configure>b__1>d.MoveNext()
--- End of stack trace from previous location ---
   at Microsoft.AspNetCore.Diagnostics.StatusCodePagesMiddleware.Invoke(HttpContext context)
   at OrchardCore.ContentPreview.PreviewStartupFilter.<>c.<<Configure>b__0_1>d.MoveNext()
--- End of stack trace from previous location ---
   at OrchardCore.Modules.ModularTenantRouterMiddleware.Invoke(HttpContext httpContext)
   at OrchardCore.Modules.ModularTenantContainerMiddleware.<>c__DisplayClass4_0.<<Invoke>b__0>d.MoveNext()
--- End of stack trace from previous location ---
   at OrchardCore.Environment.Shell.Scope.ShellScope.UsingAsync(Func`2 execute, Boolean activateShell)
   at OrchardCore.Environment.Shell.Scope.ShellScope.UsingAsync(Func`2 execute, Boolean activateShell)
   at OrchardCore.Environment.Shell.Scope.ShellScope.UsingAsync(Func`2 execute, Boolean activateShell)
   at OrchardCore.Environment.Shell.Scope.ShellScope.UsingAsync(Func`2 execute, Boolean activateShell)
   at OrchardCore.Environment.Shell.Scope.ShellScope.UsingAsync(Func`2 execute, Boolean activateShell)
   at OrchardCore.Modules.ModularTenantContainerMiddleware.Invoke(HttpContext httpContext)
   at Microsoft.AspNetCore.Authentication.AuthenticationMiddleware.Invoke(HttpContext context)
   at Microsoft.AspNetCore.Diagnostics.DeveloperExceptionPageMiddlewareImpl.Invoke(HttpContext context)

[Skrypt]

@MikeAlhayek Yeah, see that's what I meant when I said it will probably not all work magically. 🤡

[hyzx86]

Strangely, they don't look much different
But the account admin can login, and this happens when another account logsin,

Another problem was that there was no menu after the admin account logged in, even if I clicked the Dashboard button in the user menu

[hyzx86]

Maybe relate of #14572

[hyzx86]

Reason is the type of the Microsoft.AspNetCore.Identity.UserLoginInfo has no default constructor
But the User type depend on it

OrchardCore/src/OrchardCore/OrchardCore.Users.Core/Models/User.cs

Lines 46 to 50 in e35751d

	public IList<UserClaim> UserClaims { get; set; } = [];
	public IList<UserLoginInfo> LoginInfos { get; set; } = [];
	public IList<UserToken> UserTokens { get; set; } = [];

public class UserLoginInfo
{
    /// <summary>
    /// Creates a new instance of <see cref="UserLoginInfo"/>
    /// </summary>
    /// <param name="loginProvider">The provider associated with this login information.</param>
    /// <param name="providerKey">The unique identifier for this user provided by the login provider.</param>
    /// <param name="displayName">The display name for the login provider.</param>
    public UserLoginInfo(string loginProvider, string providerKey, string? displayName)
    {
        LoginProvider = loginProvider;
        ProviderKey = providerKey;
        ProviderDisplayName = displayName;
    }

[hyzx86]

Looks like the YesSqlOptions is not support to configure the ContentSerializer , shall we direct use the code below?

           if (!JOptions.Base.Converters.Any(x => x.Type == typeof(LoginInfoConverter)))
           {
               JOptions.Base.Converters.Add(new LoginInfoConverter());
           }

using System;
using System.Text.Json;
using System.Text.Json.Serialization;
using Microsoft.AspNetCore.Identity;

namespace OrchardCore.Users.Json;
public class LoginInfoConverter : JsonConverter<UserLoginInfo>
{
    public override UserLoginInfo Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSerializerOptions options)
    {
        var loginInfo = new UserLoginInfo(string.Empty, string.Empty, string.Empty);
        while (reader.Read())
        {
            if (reader.TokenType == JsonTokenType.PropertyName)
            {
                string propertyName = reader.GetString();
                reader.Read();

                switch (propertyName)
                {
                    case nameof(UserLoginInfo.LoginProvider):
                        loginInfo.LoginProvider = reader.GetString();
                        break;
                    case nameof(UserLoginInfo.ProviderKey):
                        loginInfo.ProviderKey = reader.GetString();
                        break;
                    case nameof(UserLoginInfo.ProviderDisplayName):
                        loginInfo.ProviderDisplayName = reader.GetString();
                        break;
                    default:
                        break;
                }
            }
            else if (reader.TokenType == JsonTokenType.EndObject)
            {
                break;
            }
        }

        return loginInfo;
    }

    public override void Write(Utf8JsonWriter writer,
                            UserLoginInfo objectToWrite,
                            JsonSerializerOptions options) =>
                            JsonSerializer.Serialize(writer, objectToWrite, objectToWrite.GetType(), options);
}

[MikeAlhayek]

@hyzx86 you'll need a custom converter like you did. Then register it in OC here

OrchardCore/src/OrchardCore/OrchardCore.Abstractions/Json/JOptions.cs

Line 36 in e35751d

Default.Converters.Add(new PathStringJsonConverter());

Also here

OrchardCore/src/OrchardCore/OrchardCore.Abstractions/Extensions/JsonSerializerOptionsConfiguration.cs

Line 30 in e35751d

options.Converters.Add(PathStringJsonConverter.Instance);

[hyzx86]

OrchardCore.Deployment.DeploymentStep

Deserialization of types without a parameterless constructor, a singular parameterized constructor, or a parameterized 
constructor annotated with 'JsonConstructorAttribute' is not supported. Type 'OrchardCore.Deployment.DeploymentStep'.
 Path: $.DeploymentSteps[0] | LineNumber: 0 | BytePositionInLine: 173.”

    public class DeploymentPlan
    {
        public long Id { get; set; }
        public string Name { get; set; }
        public List<DeploymentStep> DeploymentSteps { get; init; } = [];
    }
    public abstract class DeploymentStep
    {
        public string Id { get; set; }
        public string Name { get; set; }
    }

[hyzx86]

OrchardCore.Queries.Query

System.NotSupportedException:“Deserialization of types without a parameterless constructor, a singular parameterized constructor, or a parameterized constructor annotated with 'JsonConstructorAttribute' is not supported. Type 'OrchardCore.Queries.Query'. Path: $.Queries.OrderValidation | LineNumber: 0 | BytePositionInLine: 1907.”

[hyzx86]

At this point, I was curious, because it's supposed to be impossible to serialize an abstract class or a type without a default constructor.

How does Newtownsoft.Json do this?

[hyzx86]

OrchardCore.Queries.Query

System.NotSupportedException:“Deserialization of types without a parameterless constructor, a singular parameterized constructor, or a parameterized constructor annotated with 'JsonConstructorAttribute' is not supported. Type 'OrchardCore.Queries.Query'. Path: $.Queries.OrderValidation | LineNumber: 0 | BytePositionInLine: 1907.”

Hi @MikeAlhayek ， The rest of the bugs I've recorded here, the PR just handles the conversion of UserLoginInfo

[MikeAlhayek]

@hyzx86 is OrderValidation something custom you are using that is inherited from Query? If so, you'll need to register it like this

services.AddJsonDerivedTypeInfo<OrderValidation, Query>();

From the migration docs https://docs.orchardcore.net/en/latest/docs/releases/1.9.0/

Any serializable object that contains a polymorphic property (a base type that can contain sub-classes instances) needs to register all possible sub-classes this way:
services.AddJsonDerivedTypeInfo<UrlCondition, Condition>();
In particular, any type introduced in custom modules inheriting from MenuItem, AdminNode, Condition, ConditionOperator, Query, SitemapType will have to use this method.