Skip to content

Update the ContentElement constructor #15365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MikeAlhayek merged 2 commits into from
Feb 21, 2024
Merged

Update the ContentElement constructor #15365

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
211e5af
Update the ContentElement constructor
MikeAlhayek Feb 19, 2024
4a6d6f6
Merge branch 'main' into ma/content-element
MikeAlhayek Feb 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/OrchardCore/OrchardCore.ContentManagement.Abstractions/ContentElement.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,11 @@ public class ContentElement : IContent
private Dictionary<string, ContentElement> _elements;
private JsonDynamicObject _dynamicObject;

internal ContentElement() : this([])
protected ContentElement() : this([])
Copy link
Contributor

@ns8482e ns8482e Feb 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why change to protected?

Copy link
Member Author

@MikeAlhayek MikeAlhayek Feb 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because it was protected before merging the references PR. Protected will allow us to continue to be able to inherit from it and does not break anyone

{
}

internal ContentElement(JsonObject data) => Data = data;
protected ContentElement(JsonObject data) => Data = data;

[JsonIgnore]
protected internal Dictionary<string, ContentElement> Elements => _elements ??= [];
Expand Down