RTL improvements #18606
RTL improvements #18606
Conversation
- Add RTL margin override for .ms-2 class in Media navbar component - Add RTL comment for form control feedback positioning in forms component - Add RTL comments for brand wrapper title positioning in navbar component - Add RTL comments for validation error background positioning - Update compiled CSS files (TheAdmin.css and login.css) with RTL directives - Improve right-to-left language support through SCSS/CSS RTL annotations
|
Thank you for submitting your first pull request, awesome! 🚀 If you haven't already, please take a moment to review our contribution guide. This guide provides helpful information to ensure your contribution aligns with our standards. A core team member will review your pull request. If you like Orchard Core, please star our repo and join our community channels. |
|
@hishamco could you please check? |
| display: block; | ||
| position: absolute; | ||
| left: calc(var(--oc-start-navigation-width) + 10px); | ||
| left: calc(var(--oc-start-navigation-width) + 10px); /*rtl:ignore*/ |
There was a problem hiding this comment.
@Notorious-Ali what do you mean to convey when you add these comments?
There was a problem hiding this comment.
The /* rtl:ignore */ comment was used to prevent RTLCSS from auto-flipping the position. It was a leftover from the initial commit, and I’ve removed it now.
|
@Notorious-Ali, are the fixes for the above screenshots, so I can test them in Arabic |
- Remove `/*rtl:ignore*/` comment from `.has-filter .form-control-feedback` left property in _forms.scss - Remove `/*rtl:ignore*/` comment from `.brand-wrapper-title` left property in _navbar.scss - Remove `/*rtl:ignore*/` comment from `.left-sidebar-compact .ta-navbar-top .brand-wrapper-title` left property in _navbar.scss - Remove `/*rtl:ignore*/` comment from `input.input-validation-error` background-position property in _validations.scss - These comments are no longer needed as RTL handling is managed through explicit `[dir="rtl"]` selectors
Yes, those fixes cover the issues shown in the screenshots. |
|
This pull request has merge conflicts. Please resolve those before requesting a review. |
4 participants
Uh oh!
There was an error while loading. Please reload this page.