Fix Uninstall & UninstallAsync support in DataMigrationManager #18608
+263
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastienros
reviewed
Dec 4, 2025
| private const string _updateFromPrefix = "UpdateFrom"; | ||
| private const string _asyncSuffix = "Async"; | ||
|
|
||
| private static readonly Expression<Func<MethodInfo, bool>> _createMethodExpression = m |
Member
There was a problem hiding this comment.
Doesn't improve anything, it's just building a predicate dynamically, which the compiler can do at compile time. So it's actually worse. The real cost is in the reflection. If (if if ifif ) we really want to remove reflection we would need codegen.
Member
Author
There was a problem hiding this comment.
I will use reflection instead :) But that's why I used interface-based methods instead of relying on reflection in Orchard Core Contrib
hishamco
commented
Dec 5, 2025
| return null; | ||
| } | ||
|
|
||
| private static MethodInfo GetUninstallMethod(IDataMigration dataMigration) |
Member
Author
There was a problem hiding this comment.
We could merge both methods instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18607