[Optimization] compulte real max_logprobs in batch #5430
+48
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
yuanlehome
reviewed
Dec 8, 2025
| self.top_p_normalized_logprobs = True | ||
| self.prompt_logprobs_reqs: dict[str, Request] = {} | ||
| self.in_progress_prompt_logprobs: dict[str, LogprobsTensors] = {} | ||
| self.forward_batch_reqs_list: list[Request] = [None for _ in range(self.scheduler_config.max_num_seqs)] |
yuanlehome
reviewed
Dec 8, 2025
Comment on lines
+183
to
+188
| logprobs = d.get("logprobs", None) | ||
| if logprobs is not None: | ||
| if logprobs is True: | ||
| sampling_params.logprobs = d.get("top_logprobs", None) | ||
| elif logprobs is False: | ||
| sampling_params.logprobs = None |
Collaborator
There was a problem hiding this comment.
精简一下
Suggested change
| logprobs = d.get("logprobs", None) | |
| if logprobs is not None: | |
| if logprobs is True: | |
| sampling_params.logprobs = d.get("top_logprobs", None) | |
| elif logprobs is False: | |
| sampling_params.logprobs = None | |
| logprobs = d.get("logprobs", None) | |
| if logprobs: | |
| sampling_params.logprobs = d.get("top_logprobs", None) | |
| else: | |
| sampling_params.logprobs = None |
Collaborator
Author
There was a problem hiding this comment.
logprobs可能为true、false和int值[-1, 0, 1, 2,....]，chat接口需要将bool类型映射到数字或者None。
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #5430 +/- ##
==========================================
Coverage ? 59.59%
==========================================
Files ? 327
Lines ? 40666
Branches ? 6175
==========================================
Hits ? 24233
Misses ? 14555
Partials ? 1878
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
每次根据batch 请求中的真实的logprob计算，相比每次按照最大20计算，端到端性能提升10%
Modifications
无改变
Usage or Command
无改变
Accuracy Tests
已存在
Checklist
[FDConfig],[APIServer],[Engine],[Scheduler],[PD Disaggregation],[Executor],[Graph Optimization],[Speculative Decoding],[RL],[Models],[Quantization],[Loader],[OP],[KVCache],[DataProcessor],[BugFix],[Docs],[CI],[Optimization],[Feature],[Benchmark],[Others],[XPU],[HPU],[GCU],[DCU],[Iluvatar],[Metax]]pre-commitbefore commit.releasebranch, make sure the PR has been submitted to thedevelopbranch, then cherry-pick it to thereleasebranch with the[Cherry-Pick]PR tag.