Skip to content

Conversation

@fl4p
Copy link

@fl4p fl4p commented Nov 29, 2016

jsbin with paper-slider: https://jsbin.com/votacuzaxe/edit?html,output

The current work around seems no to be working anymore (compiler optimizations?).

My fix rounds the value with decimal precision.

@fl4p
Copy link
Author

fl4p commented Dec 20, 2016

Just fixed a rounding issue that made the tests fail.

And:
Checking for step < 1 is not sufficient, precision issues can occur for all non-integer steps, like 1.001. I found the only solution is to compute the decimal places of step with its string representation and use this precision for final rounding of value.

@tapionx
Copy link

tapionx commented Apr 12, 2018

i confirm the issue, please merge this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants