fix 'new Subject()' and 'new Observable()' #7585
Open
+35
−36
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
As pointed out in #7536, the docs for rxjs 7+ have specifically said this since #5307:
rxjs/apps/rxjs.dev/content/guide/subject.md
Line 368 in c15b37f
rxjs/apps/rxjs.dev/content/guide/subject.md
Line 377 in c15b37f
But the
<T = void>was removed for unexplained reasons in #5430 even though the docs were never updated.BREAKING CHANGE:
Code that depends on
new Subject()returningSubject<unknown>will break.Related issue (if exists):
This also had to fix tests missing type parameters from #3449 #5750 #6216 #6478