[macOS] Music not working (Requires Timidity to be pre-installed)

[shinra-electric]

This is a kind of follow-up to this issue.

Music is not working in War1gus. However I don't think this is due to a recent change, as previous builds I made also don't have music (I just didn't notice until now).

The logs show that it is referencing the source code folder, which doesn't exist anymore. Similar behaviour to this wartool issue

Terminal Saved Output.txt

[Jarod42]

Supported sound decoders: WAVE AIFF VOC MOD OGG OPUS MP3 FLAC WAVPACK
Supported music decoders: CMD WAVE FLAC WAVPACK OGG OPUS MPG123 XMP MOD MP3
[..]
LoadMusic: Can't load the music 'music/27.mid'

MID decoders is missing :-/ (SDL_Mixer has option for midi file (disabled by default))

I personally have (on Windows)

Supported sound decoders: WAVE AIFF VOC MID OGG MP3 FLAC
Supported music decoders: WAVE DRFLAC OGG MINIMP3 NATIVEMIDI MIDI MP3 FLAC

Alternatively, as you have ogg support, you might convert music to ogg:

war1tool [-m] [-v] [-V] [-h] archive-directory [destination-directory]
-m    Extract and convert midi sound files (may take some time)

It is the -m flag.

[legluondunet]

Could be interesting to add an option or a feature to War1gus:
If midi is not available, convert midi files to OGG

[shinra-electric]

I found the reason for this.

War1tool uses a dependency called Timidity to convert Midi files. But it's not in the list of third-party dependencies.

I installed Timidity using Homebrew and then war1tool was able to convert the audio.

In the future when trying to get war1tool in a self-contained Mac app bundle working, it's not reasonable to expect users to have Timidity installed. It should be added as a dependency and bundled with the app, or else war1tool should be modified to use a different conversion tool.

[shinra-electric]

Or actually, it's probably best not to convert the audio, but just to get MIDI support working in War1gus.

@Jarod42 what is that option for SDL_Mixer that you mentioned?

[Jarod42]

@shinra-electric: I think it was CMake option SDL2MIXER_MIDI, but I rechecked, default seems to be ON (or I confound default with MOD?).
Or maybe older SUPPORT_MID_TIMIDITY/SUPPORT_MID_FLUIDSYNTH?

[shinra-electric]

-DBUILD_VENDORED_MEDIA_LIBS needs to be ON, but this brings me back full circle to the outdated SDL_Image and libpng issue 🤦🏻‍♂️

[Jarod42]

-DBUILD_VENDORED_MEDIA_LIBS=ON relies on "our" codebase, and so can be fixed if needed.
-DBUILD_VENDORED_MEDIA_LIBS=OFF relies on system libraries; those might have "incorrect" options though.

I don't have Mac.
I cannot test war1gus' extractor :-/
My help is so limited.

[shinra-electric]

-DBUILD_VENDORED_MEDIA_LIBS=ON relies on "our" codebase, and so can be fixed if needed. -DBUILD_VENDORED_MEDIA_LIBS=OFF relies on system libraries; those might have "incorrect" options though.

My long-term goal is to get the macOS release to the point where a user can just download it and run it without installing any dependencies or messing with homebrew first.
So I'd like to get VENDORED_MEDIA_LIBS and VENDORED_SDL working if possible, and use system libraries only as a backup or a workaround.

I don't have Mac. I cannot test war1gus' extractor :-/ My help is so limited.

You've been a great help already 👍🏼
I'm in the middle of writing a data extraction script for macOS so users can get their game data, then they only need to grab the Actions build whenever there is an update to the source code.
If there are a few more Mac users for testing, maybe some of them can help with these kinds of issues.