Skip to content

Conversation

@achristmascarl
Copy link
Owner

@achristmascarl achristmascarl commented Oct 16, 2025

Important

Add concurrency configuration to cancel in-progress GitHub Actions runs for the same pull request in ci.yml.

  • Concurrency:
    • Adds concurrency configuration to .github/workflows/ci.yml to cancel in-progress runs for the same pull request using group: ci-${{ github.event.pull_request.number || github.ref }} and cancel-in-progress: true.

This description was created by Ellipsis for b3790d5. You can customize this summary. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to b3790d5 in 1 minute and 37 seconds. Click for details.
  • Reviewed 17 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. .github/workflows/ci.yml:9
  • Draft comment:
    The new concurrency block is correctly placed to cancel overlapping runs. Consider including a unique identifier (e.g. github.workflow) in the group name so that runs from different workflows don’t conflict. Also, verify that using github.ref (which might include slashes) won’t cause issues with the concurrency group naming.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 50% <= threshold 50% The comment suggests a specific improvement by including a unique identifier in the group name to avoid conflicts, which is a valid suggestion. However, it also asks the author to verify potential issues with using github.ref, which violates the rule against asking the author to verify or double-check things. The first part of the comment is useful, but the second part should be removed.

Workflow ID: wflow_qLJD9vE13zSaDb2G

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

@achristmascarl achristmascarl merged commit 98b7cf3 into main Oct 16, 2025
10 checks passed
@achristmascarl achristmascarl deleted the chore/cancel-overlapping-gh-actions branch October 16, 2025 20:14
@achristmascarl achristmascarl added the no-release-notes won't show up in release notes label Nov 2, 2025
@github-actions
Copy link

github-actions bot commented Nov 2, 2025

Included in release v0.3.9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-release-notes won't show up in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants