-
Notifications
You must be signed in to change notification settings - Fork 51
Description
Describe the bug
Github automatically creates source code archives which are commonly used by distros to fetch repositories at point releases.
These do not include the .git directory. Consequently, UWUFETCH_VERSION = $(shell git describe --tags) sets an empty string at compile time.
To Reproduce
Steps to reproduce the behavior:
- Download https://github.com/github/TheDarkBug/uwufetch/refs/heads/main.tar.gz
- Run
make build - See described result in e.g. the cc flags.
Expected behavior
Sensible version string regardless of vcs presence in archive. I propose to hardcode the string and update it upon release of a new version. Another option would be to allow users to pass the string as a make argument but this doesn't seem correct to me.
Desktop (please complete the following information):
- OS: any
- Version since 2.0
Are you already working on this bug?
I want your feedback on my proposition before proceeding with my proposition.