fix: Use assert!() for bool assertions and update expected DML errors

- Change assert_eq!(x, true/false) to assert!(x)/assert!(!x) per clippy
- Update delete.slt and update.slt expected error messages to match
  new physical planner behavior for unsupported DML operations

Author: ethan-tyler

datafusion/expr/src/logical_plan/dml.rs

@@ -356,25 +356,25 @@ mod tests {
 
     #[test]
     fn test_dml_capabilities_constants() {
-        assert_eq!(DmlCapabilities::NONE.delete, false);
-        assert_eq!(DmlCapabilities::NONE.update, false);
+        assert!(!DmlCapabilities::NONE.delete);
+        assert!(!DmlCapabilities::NONE.update);
 
-        assert_eq!(DmlCapabilities::ALL.delete, true);
-        assert_eq!(DmlCapabilities::ALL.update, true);
+        assert!(DmlCapabilities::ALL.delete);
+        assert!(DmlCapabilities::ALL.update);
 
-        assert_eq!(DmlCapabilities::DELETE_ONLY.delete, true);
-        assert_eq!(DmlCapabilities::DELETE_ONLY.update, false);
+        assert!(DmlCapabilities::DELETE_ONLY.delete);
+        assert!(!DmlCapabilities::DELETE_ONLY.update);
 
-        assert_eq!(DmlCapabilities::UPDATE_ONLY.delete, false);
-        assert_eq!(DmlCapabilities::UPDATE_ONLY.update, true);
+        assert!(!DmlCapabilities::UPDATE_ONLY.delete);
+        assert!(DmlCapabilities::UPDATE_ONLY.update);
     }
 
     #[test]
     fn test_dml_capabilities_supports_any() {
-        assert_eq!(DmlCapabilities::NONE.supports_any(), false);
-        assert_eq!(DmlCapabilities::ALL.supports_any(), true);
-        assert_eq!(DmlCapabilities::DELETE_ONLY.supports_any(), true);
-        assert_eq!(DmlCapabilities::UPDATE_ONLY.supports_any(), true);
+        assert!(!DmlCapabilities::NONE.supports_any());
+        assert!(DmlCapabilities::ALL.supports_any());
+        assert!(DmlCapabilities::DELETE_ONLY.supports_any());
+        assert!(DmlCapabilities::UPDATE_ONLY.supports_any());
     }
 
     #[test]

datafusion/sqllogictest/test_files/delete.slt

@@ -34,7 +34,7 @@ explain delete from t1;
 logical_plan
 01)Dml: op=[Delete] table=[t1]
 02)--TableScan: t1
-physical_plan_error This feature is not implemented: Unsupported logical plan: Dml(Delete)
+physical_plan_error Error during planning: Table 't1' does not support DELETE operations
 
 
 # Filtered by existing columns
@@ -45,7 +45,7 @@ logical_plan
 01)Dml: op=[Delete] table=[t1]
 02)--Filter: CAST(t1.a AS Int64) = Int64(1) AND t1.b = CAST(Int64(2) AS Utf8View) AND t1.c > CAST(Int64(3) AS Float64) AND CAST(t1.d AS Int64) != Int64(4)
 03)----TableScan: t1
-physical_plan_error This feature is not implemented: Unsupported logical plan: Dml(Delete)
+physical_plan_error Error during planning: Table 't1' does not support DELETE operations
 
 
 # Filtered by existing columns, using qualified and unqualified names
@@ -56,7 +56,7 @@ logical_plan
 01)Dml: op=[Delete] table=[t1]
 02)--Filter: CAST(t1.a AS Int64) = Int64(1) AND t1.b = CAST(Int64(2) AS Utf8View) AND t1.c > CAST(Int64(3) AS Float64) AND CAST(t1.d AS Int64) != Int64(4)
 03)----TableScan: t1
-physical_plan_error This feature is not implemented: Unsupported logical plan: Dml(Delete)
+physical_plan_error Error during planning: Table 't1' does not support DELETE operations
 
 
 # Filtered by a mix of columns and literal predicates
@@ -67,7 +67,7 @@ logical_plan
 01)Dml: op=[Delete] table=[t1]
 02)--Filter: CAST(t1.a AS Int64) = Int64(1) AND Int64(1) = Int64(1) AND Boolean(true)
 03)----TableScan: t1
-physical_plan_error This feature is not implemented: Unsupported logical plan: Dml(Delete)
+physical_plan_error Error during planning: Table 't1' does not support DELETE operations
 
 
 # Deleting by columns that do not exist returns an error

datafusion/sqllogictest/test_files/update.slt

@@ -33,7 +33,7 @@ logical_plan
 01)Dml: op=[Update] table=[t1]
 02)--Projection: CAST(Int64(1) AS Int32) AS a, CAST(Int64(2) AS Utf8View) AS b, Float64(3) AS c, CAST(NULL AS Int32) AS d
 03)----TableScan: t1
-physical_plan_error This feature is not implemented: Unsupported logical plan: Dml(Update)
+physical_plan_error Error during planning: Table 't1' does not support UPDATE operations
 
 query TT
 explain update t1 set a=c+1, b=a, c=c+1.0, d=b;
@@ -42,7 +42,7 @@ logical_plan
 01)Dml: op=[Update] table=[t1]
 02)--Projection: CAST(t1.c + CAST(Int64(1) AS Float64) AS Int32) AS a, CAST(t1.a AS Utf8View) AS b, t1.c + Float64(1) AS c, CAST(t1.b AS Int32) AS d
 03)----TableScan: t1
-physical_plan_error This feature is not implemented: Unsupported logical plan: Dml(Update)
+physical_plan_error Error during planning: Table 't1' does not support UPDATE operations
 
 statement ok
 create table t2(a int, b varchar, c double, d int);
@@ -73,7 +73,7 @@ logical_plan
 04)------Cross Join: 
 05)--------TableScan: t1
 06)--------TableScan: t2
-physical_plan_error This feature is not implemented: Unsupported logical plan: Dml(Update)
+physical_plan_error Error during planning: Table 't1' does not support UPDATE operations
 
 statement ok
 create table t3(a int, b varchar, c double, d int);
@@ -94,4 +94,4 @@ logical_plan
 05)--------SubqueryAlias: t
 06)----------TableScan: t1
 07)--------TableScan: t2
-physical_plan_error This feature is not implemented: Unsupported logical plan: Dml(Update)
+physical_plan_error Error during planning: Table 't1' does not support UPDATE operations