Move MissingPropertyException to common location

[david-livefront]

🎟️ Tracking

N/A

📔 Objective

This PR moves the MissingPropertyException to a common location so it can be reused in other modules.

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[claude]

Claude finished @david-livefront's task —— View job

---

Code Review Complete ✓

Tasks

• Analyze PR changes and context
• Perform comprehensive code review using Bitwarden standards
• Post review findings

---

Review Summary

This PR correctly moves MissingPropertyException from the app module to the core module, enabling reuse across multiple modules. The refactoring is clean and complete.

Changes Overview

What changed:

• Moved: MissingPropertyException from app/src/main/kotlin/com/x8bit/bitwarden/data/platform/error/ → core/src/main/kotlin/com/bitwarden/core/data/repository/error/
• Updated: Import statements in 10 files (5 source files + 5 test files)
• Impact: No functional changes, purely structural refactoring

Findings

👍 Positive Aspects

1. Complete refactoring: All 10 import statements correctly updated across source and test files
2. Appropriate package structure: New location com.bitwarden.core.data.repository.error follows existing core module conventions
3. No orphaned references: Verified no remaining references to the old import path
4. Module boundary adherence: The core module is the correct location for shared exception types
5. Zero functional impact: Exception implementation unchanged, purely a location move

📝 Observations

• The error directory already exists in the core module with proper structure, confirming this is the established pattern
• Other exceptions like NoActiveUserException and SecurityStampMismatchException appropriately remain in the app module (they're app-specific)
• This change enables future modules to reference MissingPropertyException without depending on the app module

Architecture Compliance

✓ Follows module organization guidelines (core module for shared utilities)
✓ Maintains proper dependency direction (app → core)
✓ Uses established package naming conventions
✓ No architecture violations introduced

Recommendation

APPROVE - This is a well-executed refactoring that improves code reusability without introducing any issues. The change is straightforward, complete, and follows established project patterns.

---

[david-livefront]

Thanks @andrebispo5

[github-actions]

Checkmarx One – Scan Summary & Details – 4f18bf4b-5225-4e8c-be75-2d4197ec0bb3

Great job! No new security vulnerabilities introduced in this pull request

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.39%. Comparing base (127809b) to head (6a919e3).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #6237   +/-   ##
=======================================
  Coverage   85.39%   85.39%           
=======================================
  Files         755      755           
  Lines       54113    54113           
  Branches     7793     7793           
=======================================
  Hits        46212    46212           
  Misses       5188     5188           
  Partials     2713     2713           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.