Skip to content

Commit 82c75b8

Browse files
chore!: update sdk-internal crates (#1370)
## 🎟️ Tracking https://bitwarden.atlassian.net/browse/SM-1738 ## 📔 Objective Update sdk-internal crates. This, unfortunately required some pretty heavy, less-than-ideal changes, which I've added comments for throughout the PR. This also fixes our failing WASM builds by removing the transpiled JS. We will only support WASM going forward. ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes
1 parent abda0ca commit 82c75b8

File tree

26 files changed

+874
-572
lines changed

26 files changed

+874
-572
lines changed

.github/workflows/build-wasm.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ jobs:
5151
key: wasm-cargo-cache
5252

5353
- name: Install wasm-bindgen-cli
54-
run: cargo install wasm-bindgen-cli --version 0.2.95
54+
run: cargo install wasm-bindgen-cli --version 0.2.105
5555

5656
- name: Build
5757
run: ./build.sh -r

0 commit comments

Comments
 (0)