Kotlin library hides errors if download fails

[weaversam8]

Wrapping this code in a try/catch means any descriptive error message will be invisible to the developer. Instead, the library just returns an opaque false which is not useful for troubleshooting:

cactus/kotlin/library/src/androidMain/kotlin/CactusLM.android.kt

Lines 18 to 34 in 087aee1

	try {
	val modelsDir = File(applicationContext.cacheDir, "models")
	if (!modelsDir.exists()) modelsDir.mkdirs()
	val modelFile = File(modelsDir, filename)
	if (modelFile.exists()) return@withContext true
	val urlConnection = URL(url).openConnection()
	urlConnection.getInputStream().use { input ->
	modelFile.outputStream().use { output ->
	input.copyTo(output)
	}
	}
	modelFile.exists()
	} catch (e: Exception) {
	false
	}

[HenryNdubuaku]

Thanks for flagging this! You could submit a PR to fix this if you want. Else, we'd do it.

[adityavarmaaa]

The problem arises because when a download fails in the Kotlin library, the catch block just returns false without exposing the cause, making it hard for developers to debug. To solve this, modify the catch block so that exceptions are either logged or conveyed up the stack—replace the current catch (e: Exception) { false } with code that logs the error message, such as catch (e: Exception) { Log.e("CactusLM", "Model download failed", e); throw e } or, if throwing isn’t feasible, return a Result object or error message instead. This ensures if a failure happens, developers see exactly why, making the library much more developer-friendly and making troubleshooting straightforward.