Add support for building release images with debug information #1655
Conversation
nickolaev
force-pushed
the
v1.34_debug
branch
from
968a29d to
427fea8
Compare
nickolaev
force-pushed
the
v1.34_debug
branch
from
3ace253 to
4bd60ac
Compare
| @@ -0,0 +1,10 @@ | |||
| name: Refresh test & build cache & build latest | |||
There was a problem hiding this comment.
Looks like this is the only difference between .github/workflows/build-envoy-images-release-debug.yaml and .github/workflows/build-envoy-images-release.yaml workflows.
You can combine these workflows into one file and calculate the debug param dynamic depending on the workflow trigger and branch.
There was a problem hiding this comment.
I wanted to have two separate workflows
nickolaev
force-pushed
the
v1.34_debug
branch
3 times, most recently
from
407aa9b to
83ae831
Compare
|
any reason to do it with 1.34 branch first ? Normally, we do the changes for main and then backport to older stable branch instead. |
Because that's where we needed it for our perf tests :) |
This woula allow calling `bazel build` with `--configure=release_debug`. The resulting binary will retain all the symbols information. It also is big, around 2GB. Signed-off-by: Nikolay Nikolaev <[email protected]>
We're passing this to the Makefile and then also in the Dockerfile. The result is calling the `bazel build --configure=release_debug` Signed-off-by: Nikolay Nikolaev <[email protected]>
We move the common image release workflow to a shareadble YAML and parametrize it. Then we include it in a release and release-debug YAML files. Signed-off-by: Nikolay Nikolaev <[email protected]>
nickolaev
force-pushed
the
v1.34_debug
branch
from
83ae831 to
cc79648
Compare
4 participants
This adds the bazel and make infrastructure to build release images with included symbols information.
It would be useful in production environments when debugging issues.
To leverage the build with CI, we move the core Release build functionality to
build-envoy-images-release-base.yamland then include it in the two new files:build-envoy-images-release.yaml- invoked on push in the branchbuild-envoy-images-release-debug.yaml- invoked on demand in the Actions UI