Fix OnDiskGraphIndex#ramBytesUsed NPE #587
Closed
+14
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaeljmarshall
requested review from
MarkWolters,
jshook,
marianotepper and
tlwillke
as code owners
marianotepper
approved these changes
Dec 3, 2025
Collaborator
marianotepper
left a comment
marianotepper
left a comment
There was a problem hiding this comment.
Good catch. Thanks!
Member
Author
CI expects the branch to be in the datastax/jvector repo. Is that intentional? Seems like we'd want to allow external contributions. |
Member
Author
|
superseded by #588 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #586
Now that we lazily load the
inMemoryNeighborsand theinMemoryFeatures, we need to handle the case where they arenullor have values that arenull. The added test fails without the change.