refactor(IDX): remove is-member check (#172)

* refactor(IDX): remove is-member check

* update path

* update

* add branch for testing

* remove branch again

Author: cgundy

.github/workflows/check_cla_ruleset.yml

@@ -15,15 +15,10 @@ permissions:
   pull-requests: write
 
 jobs:
-  check-membership:
-    uses: dfinity/public-workflows/.github/workflows/check_membership.yml@main
-    secrets: inherit
-    
   check-external-contributions:
     name: Check External Contributions
     runs-on: ubuntu-latest
-    needs: check-membership
-    if: ${{ needs.check-membership.outputs.is_member != 'true' && needs.check-membership.result == 'success' }}
+    if: github.event_name == 'pull_request_target' && github.event.pull_request.head.repo.full_name != github.repository
     steps:
       - name: Create GitHub App Token
         uses: actions/create-github-app-token@v1
@@ -44,7 +39,7 @@ jobs:
         id: accepts_external_contrib
         run: |
           export PYTHONPATH="$PWD/reusable_workflows/"
-          python reusable_workflows/check_membership/check_external_contrib.py
+          python reusable_workflows/check_cla/check_repos.py
         shell: bash
         env:
           GH_TOKEN: ${{ steps.app-token.outputs.token }}

.github/workflows/check_membership.yml

@@ -1,10 +1,26 @@
 import os
 
-from check_membership.check_membership import is_approved_bot
+APPROVED_BOT_LIST = [
+    "dependabot[bot]",
+    "dfinity-bot",
+    "github-actions[bot]",
+    "gix-bot",
+    "mergify[bot]",
+    "pr-automation-bot-public[bot]",
+    "pr-creation-bot-dfinity-ic[bot]",
+    "pr-creation-bot-dfinity[bot]",
+    "sa-github-api",
+]
+
+def is_approved_bot(user: str) -> bool:
+    """
+    Return whether the user is an approved bot.
+    """
+    return user in APPROVED_BOT_LIST
 
 
 def main() -> None:
-    user = os.getenv("USER")
+    user = os.environ["USER"]
 
     is_bot = is_approved_bot(user)
     os.system(f"""echo 'is_bot={is_bot}' >> $GITHUB_OUTPUT""")

reusable_workflows/check_membership/check_external_contrib.py renamed to reusable_workflows/check_cla/check_repos.py

@@ -4,7 +4,7 @@
 import github3
 import pytest
 
-from check_membership.check_external_contrib import (
+from check_cla.check_repos import (
     get_repos_open_to_contributions,
     main,
 )  # noqa