Page linking doesn't work and linking custom models doesn't work according to the documentation

[viktor-yunenko]

The following code:

    def real_value(self):
        return self.model.objects.filter(pk=self.link.data('value')).first()

When attached to djangocms_blog.Post model self.link.data('value') returns {'model': 7}, which of course can't be used as a filter for PK, ie self.model.objects.filter(pk={'model': 7}) returns an error.

[viktor-yunenko]

Looks like there should be validation for confirming that the link type actually returns an integer.

[viktor-yunenko]

Also when a label not set the same happens with cms.Page instances. The issue is quite problematic since it can break the site, for now I used a dirty fix:

class DjangocmsBlogPostLinkType(ModelLinkType):
    identifier = 'djangocms_blog_post'
    type_label = 'Story'
    model = Post

    def real_value(self):
        if isinstance(self.link.data('value')['model'], int):
            return self.model.objects.filter(pk=self.link.data('value')['model']).first()
        else:
            return self.model.objects.filter(pk=self.link.data('value')).first()

cc @yvladislav

[viktor-yunenko]

The dirty fix for cms.Page:

class FixedPageType(PageType):
    def real_value(self):
        if isinstance(self.link.data('value').get('page'), int):
            return Page.objects.filter(pk=self.link.data('value').get('page')).first()
        else:
            return Page.objects.filter(pk=self.link.data('value').get('page').pk).first()

In general it looks as something that requires the architecture fix rather than a small update. As a library user I would except this plugin to iterate over all registered models that have get_absolute_url method defined and register them as ModelLinkTypes. With the possibility to exclude the undesired models, eg:

LINKIT_EXCLUDED = [
    'djangocms_blog.Category',
]

Or perhaps custom inclusion as:

LINKIT_MODELS = [
    'djangocms_blog.Post',
]

Until this is done ModelLinkType.real_value() I advice to replace with:

def real_value(self) -> Model:
    raise NotImplementedError()