Fix #1331 #1648
Open
Fix #1331 #1648
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MetricObject now has a method called `describe_distance()` that prints (or returns) a recursive description of how its distance metric is computed. I'm going to add a depth-limiting option.
Contributor
Author
|
This is meant to address #1331 , which was originally marked as "Priority: Critical". That seemed hyperbolic to me, so I bumped it down to high. |
Object classes (etc) are now displayed in line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the method
describe_distance()toMetricObject, which recursively generates a description of how the distance metric is computed. Prints output to screen by default, but can return it as a string instead. Has an option to specify maximum depth, because some solution objects are complicated.I should add some tests so that most of the new code gets covered.