[locker] Show favorite functionality #7892
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| static Future<void> markMultipleAsImportant( | ||
| BuildContext context, | ||
| List<EnteFile> files, { | ||
| VoidCallback? onSuccess, | ||
| }) async { |
There was a problem hiding this comment.
The new bulk favorite helper markMultipleAsImportant is added here but never invoked; in the same commit the selection overlay removed its Important/Unmark buttons, and _getSecondaryActionsForSelection now only offers edit and "Add to". As a result, when selecting one or more items in the viewer's selection bar there is no way to favorite or unfavorite them anymore, regressing multi-select favorites despite introducing this helper.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
This will be used when the bottom sheet for multi-select files will be enabled .
Description
Screen.Recording.2025-12-09.at.4.38.15.PM.mov
Tests