Migrate Velox build to use minimum GCC-13 #15236
Replies: 3 comments 12 replies
-
|
CC: @pedroerp, @kgpai, @czentgr, @assignUser, @karthikeyann, @MBkkt |
Beta Was this translation helpful? Give feedback.
-
|
With regards to forward compatibilty Fedora already supports gcc 14 (https://github.com/facebookincubator/velox/blob/main/scripts/setup-fedora.sh#L96) and we build against it, so this should be fine. With regards to backwards compatibility unless we have any customer who objects, lets go for it. |
Beta Was this translation helpful? Give feedback.
-
|
@zhouyuan thanks for flagging this. Seems like centos 7 is end of life since 2024, which means per my understanding you aren't getting even security updates anymore. Do you have a sense on how long it will take to migrate Gluten CI (and potential other users you mentioned) to a newer version? |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
Velox recently added support for C++20 #10814
However, the current GCC-12.* that is used has minimal support for most C++ 20 features.
Example:
std::formatis not supported. See #14458Cudf 25.10 also needs support for
std::format, std::span, std::variantwhich come with GCC-13.The proposal is to make GCC-13 as the minimum and update the corresponding CentOS and Ubuntu versions.
Beta Was this translation helpful? Give feedback.
All reactions