feat: Actually land: Enhanced token management with proactive validation and expiration support #121
Conversation
- fresh: 0.4.3 -> 0.5.0 - fresh_dio: 0.4.3 -> 0.5.0 - fresh_graphql: 0.6.1 -> 0.7.0
- Replace AuthToken with Token base class - Remove automatic issuedAt setting in FreshMixin - Update OAuth2Token to extend Token instead of AuthToken - Remove outdated tests for copyWith and automatic issuedAt - Update changelogs to remove breaking change mentions Token architecture is now extensible without breaking changes.
passsy
changed the title
|
Thanks I'll take a closer look later either today or tomorrow and try to get this merged. Really appreciate you taking the time to ship these improvements 💯 |
|
I much preferred |
| @@ -1,3 +1,10 @@ | |||
| # 0.7.0 | |||
There was a problem hiding this comment.
why the bump to 0.7.0 instead of 0.5.0?
|
|
||
| environment: | ||
| sdk: ">=2.12.0 <4.0.0" | ||
| sdk: ">=3.0.0 <4.0.0" |
There was a problem hiding this comment.
The code uses, for example
if (token case Token(:final DateTime expiresAt))
You can do without it, but is it necessary to support Dart < 3.0 in new versions of the package?
| funding: [https://github.com/sponsors/felangel] | ||
|
|
||
| version: 0.4.3 | ||
| version: 0.7.0 |
There was a problem hiding this comment.
| version: 0.7.0 | |
| version: 0.5.0 |
why not 0.5.0?
There was a problem hiding this comment.
To synchronize versions in all packages? Although, perhaps this is not necessary
| dependency: | ||
| meta: ^1.10.0 |
There was a problem hiding this comment.
It seems that it is no longer necessary, so it can be removed
|
@passsy Hi, can you go back to that? |
3 participants
Building on top of #117
tested it all day, it works fine :)
The versioning and breaking changes (like raising min-sdk) need to be considered