improve mongodb migration engine

Author: fuma-nama

packages/fumadb/src/adapters/mongodb/migration/execute.ts

@@ -55,21 +55,6 @@ async function createUniqueIndex(
   });
 }
 
-async function dropUniqueIndex(
-  collection: Collection<Document>,
-  colName: string
-) {
-  if (colName === "_id") return;
-  const indexes = await collection.indexes();
-
-  for (const index of indexes) {
-    if (!index.name || !index.unique || index.key[colName] !== 1) continue;
-
-    await collection.dropIndex(index.name);
-    break;
-  }
-}
-
 async function executeColumn(
   collection: Collection<Document>,
   operation: ColumnOperation,
@@ -86,15 +71,27 @@ async function executeColumn(
       );
       return;
 
-    case "drop-column":
-      await dropUniqueIndex(collection, operation.name);
+    case "drop-column": {
+      if (operation.name === "_id")
+        throw new Error("You cannot drop `_id` column");
+      const indexes = await collection.indexes();
+
+      // drop unique index on it
+      for (const index of indexes) {
+        if (!index.name || !index.unique || index.key[operation.name] !== 1)
+          continue;
+
+        await collection.dropIndex(index.name);
+        break;
+      }
 
       await collection.updateMany(
         {},
         { $unset: { [operation.name]: "" } },
         { session }
       );
       return;
+    }
     case "create-column": {
       const col = operation.value;
       const defaultValue = col.generateDefaultValue() ?? null;
@@ -106,12 +103,6 @@ async function executeColumn(
           { session }
         );
       }
-
-      if (col.isUnique) {
-        await createUniqueIndex(collection, col.getUniqueConstraintName(), [
-          col.names.mongodb,
-        ]);
-      }
       return;
     }
 
@@ -135,16 +126,6 @@ async function executeColumn(
 
         if (bulk.batches.length > 0) await bulk.execute();
       }
-
-      if (operation.updateUnique) {
-        if (col.isUnique) {
-          await createUniqueIndex(collection, col.getUniqueConstraintName(), [
-            col.names.sql,
-          ]);
-        } else {
-          await dropUniqueIndex(collection, col.names.mongodb);
-        }
-      }
     }
   }
 }

packages/fumadb/src/adapters/prisma/query.ts

@@ -12,7 +12,6 @@ import {
   Column,
 } from "../../schema";
 import { type Condition, ConditionType } from "../../query/condition-builder";
-import { createId } from "../../cuid";
 import { checkForeignKeyOnInsert } from "../../query/polyfills/foreign-key";
 import type { PrismaConfig } from ".";