-
-
Notifications
You must be signed in to change notification settings - Fork 1
[iOS] Improve demangling performance #483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #483 +/- ##
=======================================
Coverage 81.26% 81.26%
=======================================
Files 164 164
Lines 14227 14265 +38
Branches 1505 1510 +5
=======================================
+ Hits 11562 11593 +31
- Misses 2089 2094 +5
- Partials 576 578 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bdd203b to
42ef29b
Compare
4cc9017 to
ea3c4e8
Compare
42ef29b to
1a456af
Compare
ea3c4e8 to
0429954
Compare
1a456af to
7c71de4
Compare
0664acb to
f2f1122
Compare
7c71de4 to
4bebd79
Compare
f2f1122 to
cd0e7a6
Compare
cd0e7a6 to
75d047c
Compare
1f83aa1 to
ed6e9b8
Compare
75d047c to
71f7207
Compare
71f7207 to
7c3a773
Compare
| mangled: str | ||
|
|
||
|
|
||
| def _demangle_chunk_worker( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: private functions at the bottom
| continue_on_error: bool, | ||
| demangle_uuid: str, | ||
| ) -> Dict[str, CwlDemangleResult]: | ||
| """ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: can we remove big AI comments like this
| def test_environment_variable_disables_parallel(self): | ||
| """Test LAUNCHPAD_NO_PARALLEL_DEMANGLE env var disables parallel.""" | ||
| old_value = os.environ.get("LAUNCHPAD_NO_PARALLEL_DEMANGLE") | ||
| try: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: I think this could do something like with mock.patch.dict(os.environ, {"LAUNCHPAD_NO_PARALLEL_DEMANGLE": "value"}): which is a bit easier to manage

Uh oh!
There was an error while loading. Please reload this page.