Skip to content

Conversation

@NicoHinderling
Copy link
Contributor

@NicoHinderling NicoHinderling commented Nov 19, 2025

  1. increased chunk size by 10x (Result: (80.5s → 61.4s) )
  2. added ability to process chunks in parallel (Result: (61s → ~8-15s) )

Copy link
Contributor Author

NicoHinderling commented Nov 19, 2025

@codecov
Copy link

codecov bot commented Nov 19, 2025

Codecov Report

❌ Patch coverage is 81.11111% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.26%. Comparing base (4f57bae) to head (7c3a773).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/launchpad/utils/apple/cwl_demangle.py 76.19% 10 Missing and 5 partials ⚠️
tests/integration/test_cwl_demangle.py 92.59% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #483   +/-   ##
=======================================
  Coverage   81.26%   81.26%           
=======================================
  Files         164      164           
  Lines       14227    14265   +38     
  Branches     1505     1510    +5     
=======================================
+ Hits        11562    11593   +31     
- Misses       2089     2094    +5     
- Partials      576      578    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@NicoHinderling NicoHinderling changed the base branch from 11-19-_ios_improve_lief_parsing_performance_add_cache_remove_expensive_unused_configs to graphite-base/483 November 21, 2025 20:23
@NicoHinderling NicoHinderling force-pushed the 11-19-_ios_improve_demangling_performance branch from 4cc9017 to ea3c4e8 Compare November 21, 2025 20:23
@NicoHinderling NicoHinderling changed the base branch from graphite-base/483 to 11-21-_ios_improve_lief_parsing_performance_with_configs November 21, 2025 20:24
@NicoHinderling NicoHinderling force-pushed the 11-21-_ios_improve_lief_parsing_performance_with_configs branch from 42ef29b to 1a456af Compare November 21, 2025 20:27
@NicoHinderling NicoHinderling force-pushed the 11-19-_ios_improve_demangling_performance branch from ea3c4e8 to 0429954 Compare November 21, 2025 20:27
@NicoHinderling NicoHinderling force-pushed the 11-21-_ios_improve_lief_parsing_performance_with_configs branch from 1a456af to 7c71de4 Compare November 21, 2025 20:34
@NicoHinderling NicoHinderling force-pushed the 11-19-_ios_improve_demangling_performance branch 2 times, most recently from 0664acb to f2f1122 Compare November 21, 2025 20:35
@NicoHinderling NicoHinderling force-pushed the 11-21-_ios_improve_lief_parsing_performance_with_configs branch from 7c71de4 to 4bebd79 Compare November 21, 2025 20:35
@NicoHinderling NicoHinderling force-pushed the 11-19-_ios_improve_demangling_performance branch from f2f1122 to cd0e7a6 Compare November 21, 2025 20:48
@NicoHinderling NicoHinderling marked this pull request as ready for review November 21, 2025 20:48
@NicoHinderling NicoHinderling force-pushed the 11-19-_ios_improve_demangling_performance branch from cd0e7a6 to 75d047c Compare November 21, 2025 21:24
@NicoHinderling NicoHinderling force-pushed the 11-21-_ios_improve_lief_parsing_performance_with_configs branch 2 times, most recently from 1f83aa1 to ed6e9b8 Compare November 21, 2025 21:38
@NicoHinderling NicoHinderling force-pushed the 11-19-_ios_improve_demangling_performance branch from 75d047c to 71f7207 Compare November 21, 2025 21:38
Base automatically changed from 11-21-_ios_improve_lief_parsing_performance_with_configs to main November 21, 2025 21:59
@NicoHinderling NicoHinderling force-pushed the 11-19-_ios_improve_demangling_performance branch from 71f7207 to 7c3a773 Compare November 21, 2025 21:59
mangled: str


def _demangle_chunk_worker(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: private functions at the bottom

continue_on_error: bool,
demangle_uuid: str,
) -> Dict[str, CwlDemangleResult]:
"""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: can we remove big AI comments like this

def test_environment_variable_disables_parallel(self):
"""Test LAUNCHPAD_NO_PARALLEL_DEMANGLE env var disables parallel."""
old_value = os.environ.get("LAUNCHPAD_NO_PARALLEL_DEMANGLE")
try:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I think this could do something like with mock.patch.dict(os.environ, {"LAUNCHPAD_NO_PARALLEL_DEMANGLE": "value"}): which is a bit easier to manage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants