fix: diff scrolling on a commit preview #11499
Merged
+2
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR attempts to fix diff scrolling behavior in the commit preview by adding overflow: hidden to the .dropzone-container CSS class in Dropzone.svelte. The change aims to prevent incorrect or blocked scrolling when viewing commit diffs.
Key Changes
- Added
overflow: hiddento.dropzone-containerCSS class in Dropzone component
PavelLaptev
force-pushed
the
fix-diff-scrolling-commit-preview
branch
from
7a3c4bf to
274c7cc
Compare
| overlay?: Snippet<[{ hovered: boolean; activated: boolean; handler?: DropzoneHandler }]>; | ||
| children?: Snippet; | ||
| overflow?: boolean; | ||
| } |
There was a problem hiding this comment.
The overflow prop is still being used by WorktreeChanges.svelte (line 116) and passed from UnassignedView.svelte (line 119). Removing this prop will break the functionality in those components.
To properly implement this fix, you should also:
- Remove the
overflowprop fromWorktreeChanges.svelteinterface (line 30) and props destructuring (line 44) - Remove the
overflowprop being passed fromUnassignedView.svelte(line 119)
PavelLaptev
force-pushed
the
fix-diff-scrolling-commit-preview
branch
from
d67d936 to
e534028
Compare
PavelLaptev
force-pushed
the
fix-diff-scrolling-commit-preview
branch
from
e534028 to
6ca5a4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the issue of being unable to scroll on the commit preview. I’ve added
overflow: hiddenand an optional thing (hopefully this won’t break anything).Before (I'm trying to scroll there):
Screen.Recording.2025-12-09.at.11.19.32.mov
After:
Screen.Recording.2025-12-09.at.11.19.55.mov