Skip to content

Commit d20e6a5

Browse files
Fix typos & CvConstRef.resolve() issue detected by copilot code review
1 parent 3d0722e commit d20e6a5

File tree

1 file changed

+5
-7
lines changed

1 file changed

+5
-7
lines changed

cpp/common/src/codingstandards/cpp/types/Resolve.qll

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ module ReferenceOf<Qtil::Signature<Type>::Type ReferencedType> {
3838
* - `resolvedType.resolve()` gets the fully resolved class type for the above.
3939
* - `ResolvesTo<ClassType>::Specified` is the set of types that resolve to a specified class type.
4040
* - `ResolvesTo<ClassType>::Ref` is the set of types that resolve to a reference to a class type.
41-
* - `ResolvesTo<ClassType>::Const` is the set of types that resolve to a const class type.
41+
* - `ResolvesTo<ClassType>::CvConst` is the set of types that resolve to a const class type.
4242
* - `ResolvesTo<ClassType>::IgnoringSpecifiers` is the set of types that resolve to a class type
4343
* ignoring specifiers.
4444
* - `ResolvesTo<ClassType>::ExactlyOrRef` is the set of types that resolve to a class type and
@@ -59,7 +59,7 @@ module ResolvesTo<Qtil::Signature<Type>::Type ResolvedType> {
5959
final class CppType = cpp::Type;
6060

6161
/**
62-
* A type that resolve exactly to the module's `ResolvedType` type parameter.
62+
* A type that resolves exactly to the module's `ResolvedType` type parameter.
6363
*
6464
* For example, `ResolvesTo<FooType>::Type` is the set of all `FooType`s and types that resolve
6565
* (through typedefs * and/or decltypes) to `FooType`s. This does _not_ include types that resolve
@@ -180,7 +180,7 @@ module ResolvesTo<Qtil::Signature<Type>::Type ResolvedType> {
180180
}
181181

182182
/**
183-
* A type that resolves to a reference to that resolves to the module's `ResolvedType` type
183+
* A type that resolves to a reference that resolves to the module's `ResolvedType` type
184184
* parameter.
185185
*
186186
* For example, `ResolvesTo<FooType>::Ref` is the set of all references to `FooType`s and types
@@ -213,8 +213,6 @@ module ResolvesTo<Qtil::Signature<Type>::Type ResolvedType> {
213213
ResolvedType resolve() { result = resolved }
214214
}
215215

216-
//class Ref =
217-
//Impl::ResolveRefType;
218216
/**
219217
* A type that resolves to a const reference of (or reference to const of) the module's
220218
* `ResolvedType` type parameter.
@@ -248,15 +246,15 @@ module ResolvesTo<Qtil::Signature<Type>::Type ResolvedType> {
248246
// Note that the extractor appears to perform reference collapsing, so cases like
249247
// `const T& &` are treated as `const T&`.
250248
refType = typeResolvesToTypeStep*(this) and
251-
refType.getBaseType() instanceof CvConst
249+
resolved = refType.getBaseType().(CvConst).resolve()
252250
)
253251
}
254252

255253
ResolvedType resolve() { result = resolved }
256254
}
257255

258256
/**
259-
* A type that resolves to either a reference to that resolves to the module's `ResolvedType` type
257+
* A type that resolves to either a reference that resolves to the module's `ResolvedType` type
260258
* parameter, or exactly to the `ResolvedType`.
261259
*/
262260
class ExactlyOrRef extends CppType {

0 commit comments

Comments
 (0)