fix(infra): Revert trial build logic to select successful projects

[hunsche]

This PR reverts the logic change introduced in cabb693. The intention of trial builds is to verify that changes to base images do not break existing healthy projects. The regression caused the script to select failed projects instead, which defeats the purpose of regression testing.

[hunsche]

/gcbrun trial_build.py zlib

[jonathanmetzman]

lgtm
Thanks!

[jonathanmetzman]

Maybe also check if a broken project gets skipped!

[jonathanmetzman]

It looks like zlib is failing now because of the migration :-(

[hunsche]

It looks like zlib is failing now because of the migration :-(

It doesn't seem to be related to the migration. The issue happens in the legacy version as well.

[jonathanmetzman]

I'm confused about this
https://oss-fuzz-build-logs.storage.googleapis.com/index.html#zlib
it's not happening at all in "prod"
The error is a common one when building something in one distro and using in another. I think it's likely trial_build is not respecting ubuntu24 in project.yaml

[hunsche]

I'm confused about this https://oss-fuzz-build-logs.storage.googleapis.com/index.html#zlib it's not happening at all in "prod" The error is a common one when building something in one distro and using in another. I think it's likely trial_build is not respecting ubuntu24 in project.yaml

This doesn't seem related to the migration. It looks like the breakage started today, as it has been building correctly with ubuntu-24-04 every day since 12/04. If you check the builds from 12/04 through 12/08, they all passed. Only today's build (12/09) failed, which suggests it was caused by a recent change.

Also, take a look at the logs; it is pulling ubuntu-24-04:

Step #1 - "build-f7dfa9aa-fe1c-49f9-822b-fc4e8ee1e90c": Step 1/5 : FROM gcr.io/oss-fuzz-base/base-builder:ubuntu-24-04
Step #1 - "build-f7dfa9aa-fe1c-49f9-822b-fc4e8ee1e90c": ubuntu-24-04: Pulling from oss-fuzz-base/base-builder

[hunsche]

/gcbrun trial_build.py bad_example gcloud-go zlib