Skip to content

Conversation

@jleuth
Copy link
Collaborator

@jleuth jleuth commented Dec 5, 2025

No description provided.

@jleuth jleuth requested a review from Copilot December 5, 2025 00:44
Copilot finished reviewing on behalf of jleuth December 5, 2025 00:45
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds Git URL validation to the projects API endpoints to enhance security by ensuring repository URLs meet specific criteria before being stored in the database.

Key Changes:

  • Adds regex pattern-based validation for Git repository URLs (HTTPS only, ending in .git)
  • Implements additional security checks: URL length validation (max 256 characters) and localhost blocking
  • Applies validation to both create_project and update_project endpoints

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jleuth jleuth marked this pull request as ready for review December 5, 2025 00:50
+ use validators module instead of regex
+ format
@ImShyMike ImShyMike requested a review from Copilot December 5, 2025 17:05
Copilot finished reviewing on behalf of ImShyMike December 5, 2025 17:08
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ImShyMike ImShyMike self-requested a review December 5, 2025 17:12
@ImShyMike ImShyMike merged commit 23a97f2 into main Dec 5, 2025
1 check passed
Copy link
Collaborator

@thesleepyniko thesleepyniko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants