-
Notifications
You must be signed in to change notification settings - Fork 0
Git url validation redone #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request adds Git URL validation to the projects API endpoints to enhance security by ensuring repository URLs meet specific criteria before being stored in the database.
Key Changes:
- Adds regex pattern-based validation for Git repository URLs (HTTPS only, ending in
.git) - Implements additional security checks: URL length validation (max 256 characters) and localhost blocking
- Applies validation to both
create_projectandupdate_projectendpoints
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
+ use validators module instead of regex + format
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
thesleepyniko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :3
No description provided.