Add bans #226
Merged
Add bans #226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sentry[bot]](https://avatars.githubusercontent.com/u/1396951?s=60&v=4){kind=small}
Comment on lines
+163
to
+165
| def unban! | ||
| update!(banned: false, banned_at: nil, banned_reason: nil) | ||
| end |
There was a problem hiding this comment.
Bug: unban! does not restore soft-deleted projects, leaving them hidden after unbanning.
Severity: HIGH | Confidence: High
🔍 Detailed Analysis
The unban! method only reverses the banned status of a user by updating banned, banned_at, and banned_reason fields. It does not invoke any restore operation for projects that were soft-deleted when the user was banned via the ban! method's call to soft_delete_projects!. This results in projects remaining hidden even after a user is unbanned.
💡 Suggested Fix
Modify the unban! method to call restore! on all projects associated with the user that were soft-deleted during the ban process.
🤖 Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: app/models/user.rb#L163-L165
Potential issue: The `unban!` method only reverses the `banned` status of a user by
updating `banned`, `banned_at`, and `banned_reason` fields. It does not invoke any
restore operation for projects that were soft-deleted when the user was banned via the
`ban!` method's call to `soft_delete_projects!`. This results in projects remaining
hidden even after a user is unbanned.
Did we get this right? 👍 / 👎 to inform future reviews.
Reference ID: 6038005
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.