remove eslint from dep, add as peer dep

[y-nk]

Runtime

nodejs

Runtime version

not relevant

Module version

latest

Used with

No response

Any other relevant information

No response

What problem are you trying to solve?

Our infrastructure currently rely on eslint@8 for various reasons, but we can't run our own eslint since eslint@9 is required as dep of lab.

Do you have a new or modified API suggestion to solve the problem?

pass it as peer dep

[Marsup]

You can have both and run your own, lab using eslint 9 isn't preventing you from using eslint 8, but you won't be able to use eslint 8 through lab 26 if that's what you mean, you'd have to stick to lab 25 for this.

[y-nk]

it's impossible to pnpm exec eslint and hope v8 runs because v9 is picked by default. the only way is to add an override to eslint@8

[Marsup]

This is not how package managers work in node. With a package.json configured like this:

{
  "dependencies": {
    "@hapi/lab": "^26.0.0",
    "eslint": "^8.57.1"
  }
}

I can absolutely confirm that it works as expected:

❯ pnpm exec eslint --version
v8.57.1

[y-nk]

that is if you explicitly declare ; current case (i should have mentioned, sorry) is in a pnpm monorepo where the monorepo root installs eslint.

/ → monorepo root
/package.json → has eslint@8
/workspace1
/workspace1/package.json → has @hapi/lab ; has not eslint

cd workspace1 && pnpm exec eslint --version → @9

this works as intended from monorepo POV because workspace dependencies are above monorepo dependencies by design, but then there's no way to pass around this.

usually eslint is more a dev dep, although just a peer dep would make it possible to make it work without disrupting much.

[Marsup]

Then I would say you were in a lucky coincidence, you should have ESLint declared in all the packages that use it. Why not use pnpm catalogs for that?

[y-nk]

that's an interesting development :)

i have tried to use pnpm catalogs but afaik renovatebot - which we use for dep management - does not scan/update catalog file (i may be mistaken or misconfigure it, but last we tried as unsuccessful).

as a minor side effect, we'd also need to use pnpm deploy so that catalog entries would be replaced by their matching semver in the manifest file, which at the moment is not needed.

[Marsup]

It is supported https://github.com/orgs/community/discussions/150782, but I'll agree it's a bit of work for the deployment, maybe just add eslint everywhere?

[Marsup]

Oh sorry, wrong update manager, but renovate also does renovatebot/renovate#30079

Edit :although it seems it only tolerates catalogs but doesn't apply updates to it, so maybe that's not enough for you indeed