Skip to content

Conversation

@raoufswe
Copy link
Member

@raoufswe raoufswe commented Nov 3, 2025

Describe your changes (can list changeset entries if preferable)

  • This PR adds a new plugin called stylelint-pie-design-tokens to our stylelint-config-pie package
  • The purpose of the plugin is to validate the usage of pie tokens in repos such as flagging deprecated and undefined tokens
  • The plugin is tested in the consumer web codebase, and more feedback from different consumers will be done!

Author Checklist (complete before requesting a review, do not delete any)

  • I have performed a self-review of my code.
  • I have added thorough tests where applicable (unit / component / visual).
  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have reviewed visual test updates properly before approving.
  • If changes will affect consumers of the package, I have created a changeset entry.
  • If a changeset file has been created, I have tested these changes in PIE Aperture using the /test-aperture command.
  • I have filled out the DS Review Tracker checklist (Moving PR to "Ready to Review")

Not-applicable Checklist items

Please move any Author checklist items that do not apply to this pull request here.


Testing

How do I test my changes?

Task Link
Aperture PR 🔗
NextJS 14 deployment 🔗
Nuxt 3 deployment 🔗
Vanilla deployment 🔗

Reviewer checklists (complete before approving)

Mark items as [-] N/A if not applicable.

Reviewer 1

  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have verified that all acceptance criteria for this ticket have been completed.
  • I have reviewed the Aperture changes (if added)
  • If there are visual test updates, I have reviewed them.

Reviewer 2

  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have verified that all acceptance criteria for this ticket have been completed.
  • I have reviewed the Aperture changes (if added)
  • If there are visual test updates, I have reviewed them.

@raoufswe raoufswe requested a review from a team as a code owner November 3, 2025 16:04
@changeset-bot
Copy link

changeset-bot bot commented Nov 3, 2025

🦋 Changeset detected

Latest commit: 8727d48

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@raoufswe raoufswe changed the title Dsw 3499 init styelint tokens feat(pie-monorepo): DSW-3499 init stylelint-pie-design-tokens Nov 3, 2025
@raoufswe

This comment was marked as outdated.

@pie-design-system-bot

This comment was marked as outdated.

@pie-design-system-bot

This comment was marked as outdated.

@pie-design-system-bot

This comment was marked as outdated.

@github-actions github-actions bot temporarily deployed to storybook-pr-2603 November 3, 2025 16:08 Inactive
@github-actions github-actions bot temporarily deployed to storybook-testing-pr-2603 November 3, 2025 16:08 Inactive
@raoufswe

This comment was marked as outdated.

@pie-design-system-bot

This comment was marked as outdated.

@raoufswe

This comment was marked as outdated.

@pie-design-system-bot

This comment was marked as outdated.

@raoufswe

This comment was marked as outdated.

@pie-design-system-bot

This comment was marked as outdated.

@pie-design-system-bot

This comment was marked as outdated.

@github-actions github-actions bot temporarily deployed to storybook-testing-pr-2603 November 3, 2025 16:24 Inactive
@github-actions github-actions bot temporarily deployed to storybook-pr-2603 November 3, 2025 16:25 Inactive
@raoufswe
Copy link
Member Author

raoufswe commented Nov 3, 2025

/snapit

@pie-design-system-bot
Copy link
Contributor

Starting a new snapshot build. You can view the logs here.

@pie-design-system-bot
Copy link
Contributor

@raoufswe Your snapshots have been published to npm!

Test the snapshots by updating your package.json with the newly-published versions:

Note

If you have more than one of these packages installed, we suggest using the new snapshots for all of them to help avoid version conflicts.

yarn up @justeattakeaway/[email protected] --mode=update-lockfile
yarn up @justeattakeaway/stylelint-pie-design-tokens@0.0.0-snapshot-release-20251103162954 --mode=update-lockfile

Then finally:

yarn install

@github-actions github-actions bot temporarily deployed to storybook-testing-pr-2603 November 3, 2025 16:32 Inactive
@github-actions github-actions bot temporarily deployed to storybook-pr-2603 November 3, 2025 16:33 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants