fix(toc): more clean toc rendering #187
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves Table of Contents (TOC) generation to correctly handle documents that start with H2 (or lower) headers, and optimizes the parsing logic.
Close: #186
Changes
src/render/html.zigmin_level) in the document and uses that as the root.<ul></ul>tags.Tests
tests/rendering/toc_bug/reproduction case.index.smdwith only H2 headers.snapshot/toc/index.htmlconfirms a flat<ul>list without nested empty items.Breaking
Before, detecting whether a toc is empty we use
$page.toc().len().gt(10), but now we use$page.toc().len().gt(0).