[manila-csi-plugin] Manila driver does not delete #3027
Description
/kind bug
What happened:
Tried to create a Manila share but the creation was not successful because the Manila service was under maintenance at the time. At that point, the share entered a terminal error state. Of course, that is no issue with the driver itself.
What you expected to happen:
For the volume to be deleted eventually, once the Manila service was healthy. The driver would attempt to delete it if it had a known manila error code. However the log line below indicates that this was never the case.
The driver should be entering the GetOrCreate segment here and eventually failing here.
The argument here is that by the time we found the share by name and waiting for it's status, it shouldn't matter if the error state is caused by a known condition. Rather we should try to delete it regardless.
Anything else we need to know?:
{"log":"[ID:134] GRPC error: rpc error: code = Internal desc = failed to create volume pv-shoot--hc-can-cc--536-4e-haas-47c13685-6bec-40ce-97c4-be831e540616: share 560a91b6-6874-4f83-849c-5a3241e9bc6c is in error state \"error\": unknown error","pid":"1","severity":"ERR","source":"driver.go:331"}
Environment:
- openstack-cloud-controller-manager(or other related binary) version:
- OpenStack version:
- Others: