-
Notifications
You must be signed in to change notification settings - Fork 15.1k
kep-4781: follow up 52876 #53517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev-1.35
Are you sure you want to change the base?
kep-4781: follow up 52876 #53517
Conversation
👷 Deploy Preview for kubernetes-io-vnext-staging processing.
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cc @lmktfy |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
e4d2977 to
29e6c74
Compare
29e6c74 to
25eb504
Compare
...eference/command-line-tools-reference/feature-gates/ChangeContainerStatusOnKubeletRestart.md
Outdated
Show resolved
Hide resolved
25eb504 to
db77334
Compare
| When disabled, kubelet restarts will not change the status of Pods already running on the node, | ||
| This Feature Gate was introduced to allow revert the behavior to previously used default. | ||
| Enable legacy writes to update container `ready` status after the kubelet detects a | ||
| [restart](docs/concepts/workloads/pods/pod-lifecycle/#kubelet-restarts). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The link is broken it's missing a starting / and points to a section that does not exist on the page.
I have added a suggestion below for what I think it should be.
| [restart](docs/concepts/workloads/pods/pod-lifecycle/#kubelet-restarts). | |
| [restart](/docs/concepts/workloads/pods/pod-lifecycle/#restart-policy). |
Description
This is a follow-up to the review comments on PR #52876. Due to the approaching docs freeze, we did not have time to address these comments earlier, and we will resolve these outstanding comments in this PR.
Issue
Closes: #