-
Notifications
You must be signed in to change notification settings - Fork 15.1k
Automate KubeCon event listings #53519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
lmktfy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good, but there's a challenge: how does this interact with localization?
- eg: make sure to mark the text as left to right in case the parent page isn't
- eg: we might want to use a localized date format
- other ideas can fit too
/area web-development
| """Scrape KubeCon events from Linux Foundation calendar""" | ||
|
|
||
| headers = { | ||
| 'User-Agent': 'Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/120.0.0.0 Safari/537.36' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: this is mildly deceptive
Thanks for the feedback! Here's what we can do:
other suggestions are welcome too |
singh1203
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@Caesarsage, Thank you. This is a solid implementation that eliminates the need for manual event updates. The filtering logic and error handling are particularly well done.
| # Configuration | ||
| EVENT_URL = "https://events.linuxfoundation.org/about/calendar/?_sf_s=kubecon" | ||
| EVENT_LIMIT = 2 | ||
| OUTPUT_PATH = "data/kubecon_events.yaml" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Non-blocking: This could also use CLI flags for URL/limit/output to help with local testing, but the current constant-based approach is also reasonable for a small maintenance script.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: singh1203 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
This idea seems interesting :)
region name - does it mean country name and city name ? for example in: there is "North America" + "Atlanta". |
|
I'd say that the region is "North America". KubeCon North America was most recently held in the city of Atlanta. |
|
Either before or after we merge this, we could ask the CNCF for a more machine readable version of the page we scrape. Maybe there is a WordPress plugin that can add RDFa data to the event feed or something? Or they can serve the data we're after as jCalendar? |
Yes, i agree with this |
How do one get this informations from CNCF |
|
To contact the CNCF, we use https://github.com/cncf/servicedesk @kubernetes/sig-docs-leads can send a message on your / our behalf @Caesarsage (and it's OK to propose that!) |
nate-double-u
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @Caesarsage
A concern: this may circumvent the steering committee's ability to approve site-wide changes. Usually any update to the banner needs to be approved. Tho, I suppose if this is run and generates a PR that could be approved that would alleviate the concern.
Also, each banner has a UTM link associated with it generated by the LF Marketing team that wouldn't be captured by scraping the event page.
How would this manage scheduling the banners (and ensure there is no overlap between existing banners, or if there is, how would this decide which has precedence)?
|
There are several places we mention KubeCon. This PR is about mentioning it on https://k8s.io/ (and localized equivalents) We also have site wide banners, that this PR doesn't plan to touch. For an Urchin / Google Analytics string, we could put that into a Netlify variable and inject it into production builds. The string isn't secret but putting it into a variable helps avoid tainting the metrics with forks and stale site. |
Description
Replaces hardcoded KubeCon event links with an automated system that fetches and displays events from the Linux Foundation calendar.
Changes
content/en/_index.htmlkubecon-events.htmlshortcode for dynamic event renderingdata/kubecon_events.yamlcontaining structured event data generated from scripts/fetch_kubecon_eventsscripts/fetch_kubecon_events.pyto scrape and generate event dataTo Update Events
Preview
Related to #52376