Skip to content

Commit 8a66407

Browse files
committed
Bumped version and fixed formatting.
1 parent c6b8b17 commit 8a66407

File tree

5 files changed

+28
-15
lines changed

5 files changed

+28
-15
lines changed

.github/workflows/main.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ on:
1515
jobs:
1616
build-and-test:
1717
runs-on: macos-latest
18-
timeout-minutes: 40
18+
timeout-minutes: 30
1919
strategy:
2020
matrix:
2121
flutter-version: ['3.27.4', '3.29.3', '3.32.8', '3.35.7']
@@ -47,7 +47,7 @@ jobs:
4747
files: lcov.info
4848

4949
- name: Boot the simulator
50-
run: xcrun simctl boot 'iPhone 16'
50+
run: xcrun simctl boot 'iPhone 17'
5151

5252
- name: Run the driver test
5353
run: cd example; flutter drive --target=test/driver_test/driver.dart --driver=test/driver_test/driver_test.dart

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
## 12.2.0
2+
3+
- [521] [522] Added fallback version parsing for regional Play Store pages. (thanks to youngkiu)
4+
15
## 12.1.0
26

37
- Added the showPrompt parameter to UpgradeAlert and UpgradeCard to hide the display of the prompt. (thanks to @EArminjon)

lib/src/play_store_search_api.dart

Lines changed: 14 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -280,7 +280,8 @@ extension PlayStoreResults on PlayStoreSearchAPI {
280280
storeVersionStartIndex, storeVersionEndIndex);
281281

282282
if (debugLogging) {
283-
print('upgrader: PlayStoreResults.redesignedVersion: extracted storeVersion="$storeVersion"');
283+
print(
284+
'upgrader: PlayStoreResults.redesignedVersion: extracted storeVersion="$storeVersion"');
284285
}
285286

286287
// storeVersion might be empty, null, or 'Varies with device', which is not a valid version.
@@ -293,11 +294,13 @@ extension PlayStoreResults on PlayStoreSearchAPI {
293294
try {
294295
version = Version.parse(storeVersion).toString();
295296
if (debugLogging) {
296-
print('upgrader: PlayStoreResults.redesignedVersion: successfully parsed version="$version"');
297+
print(
298+
'upgrader: PlayStoreResults.redesignedVersion: successfully parsed version="$version"');
297299
}
298300
} on FormatException catch (e) {
299301
if (debugLogging) {
300-
print('upgrader: PlayStoreResults.redesignedVersion: invalid version format "$storeVersion": $e');
302+
print(
303+
'upgrader: PlayStoreResults.redesignedVersion: invalid version format "$storeVersion": $e');
301304
}
302305
// If version parsing failed, try alternative pattern (for regional pages)
303306
version = _parseVersionAlternative(response, debugLogging);
@@ -340,8 +343,8 @@ extension PlayStoreResults on PlayStoreSearchAPI {
340343
final pattern = '"$key":[[["';
341344
const patternEndOfString = '"';
342345

343-
final versionElements = scripts.where(
344-
(element) => element.text.contains(pattern));
346+
final versionElements =
347+
scripts.where((element) => element.text.contains(pattern));
345348

346349
if (versionElements.isNotEmpty) {
347350
final versionElement = versionElements.first.text;
@@ -363,7 +366,8 @@ extension PlayStoreResults on PlayStoreSearchAPI {
363366
try {
364367
final parsed = Version.parse(storeVersion);
365368
if (debugLogging) {
366-
print('upgrader: PlayStoreResults._parseVersionAlternative: found version="$storeVersion" with key=$key');
369+
print(
370+
'upgrader: PlayStoreResults._parseVersionAlternative: found version="$storeVersion" with key=$key');
367371
}
368372
return parsed.toString();
369373
} on FormatException {
@@ -377,12 +381,14 @@ extension PlayStoreResults on PlayStoreSearchAPI {
377381
}
378382

379383
if (debugLogging) {
380-
print('upgrader: PlayStoreResults._parseVersionAlternative: no valid version found in common patterns');
384+
print(
385+
'upgrader: PlayStoreResults._parseVersionAlternative: no valid version found in common patterns');
381386
}
382387
return null;
383388
} catch (e) {
384389
if (debugLogging) {
385-
print('upgrader: PlayStoreResults._parseVersionAlternative exception: $e');
390+
print(
391+
'upgrader: PlayStoreResults._parseVersionAlternative exception: $e');
386392
}
387393
return null;
388394
}

pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
name: upgrader
22
description: Flutter package for prompting users to upgrade when there is a newer version of the app in the store.
3-
version: 12.1.0
3+
version: 12.2.0
44
homepage: https://github.com/larryaasen/upgrader
55

66
environment:

test/play_store_issue521_test.dart

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,8 @@ void main() {
3333
// FIXED: Issue #521 has been fixed! Now it successfully parses regional pages
3434
// Using alternative pattern "141":[[["1.5.1" for regional Play Store pages
3535
expect(version, equals('1.5.1'),
36-
reason: 'FIXED #521: Version parsing now works for regional Play Store pages using alternative pattern');
36+
reason:
37+
'FIXED #521: Version parsing now works for regional Play Store pages using alternative pattern');
3738
}, skip: false);
3839

3940
test('testing redesignedVersion for issue #521', () async {
@@ -59,7 +60,8 @@ void main() {
5960
// FIXED: Now successfully parses regional pages using alternative pattern
6061
// Falls back to "141":[[["1.5.1" pattern when main pattern fails
6162
expect(version, equals('1.5.1'),
62-
reason: 'FIXED #521: redesignedVersion now handles regional Play Store pages correctly');
63+
reason:
64+
'FIXED #521: redesignedVersion now handles regional Play Store pages correctly');
6365
}, skip: false);
6466

6567
test('FormatException issue #521 is now fixed', () async {
@@ -84,6 +86,7 @@ void main() {
8486

8587
// FIXED: Now returns the actual version instead of null
8688
expect(version, equals('1.5.1'),
87-
reason: 'FIXED #521: Version parsing now works correctly for regional Play Store pages');
89+
reason:
90+
'FIXED #521: Version parsing now works correctly for regional Play Store pages');
8891
}, skip: false);
89-
}
92+
}

0 commit comments

Comments
 (0)