fix bug that would cause johnsons to forget you before a run ended

Author: scoutyoshimoto

src/quest.cpp

@@ -1721,10 +1721,8 @@ SPECIAL(johnson)
         send_to_char(ch, "[OOC: This Johnson caps out at %d reputation, so you won't get any further work from them.]\r\n", johnson_max_rep);
 
         GET_SPARE1(johnson) = -1;
-        if (memory(johnson, ch)) {
-          if (PLR_FLAGGED(ch, PLR_DOING_FAVOUR)) {
-            PLR_FLAGS(ch).RemoveBit(PLR_DOING_FAVOUR);
-            }
+        //We need to ensure that trying to start a job when you are already doing a favour won't get you blanked
+        if (memory(johnson, ch) && !PLR_FLAGGED(ch, PLR_DOING_FAVOUR)) {
             forget(johnson, ch);
           }
         return TRUE;
@@ -1828,9 +1826,6 @@ SPECIAL(johnson)
 
         GET_SPARE1(johnson) = -1;
         if (memory(johnson, ch)) {
-          if (PLR_FLAGGED(ch, PLR_DOING_FAVOUR)) {
-            PLR_FLAGS(ch).RemoveBit(PLR_DOING_FAVOUR);
-          }
           forget(johnson, ch);
         }
         return TRUE;