From 995ab5c3bfee4ed4575a8f28df9e1b8c6d317d51 Mon Sep 17 00:00:00 2001 From: Ashwath Date: Thu, 20 Nov 2025 20:45:58 +0530 Subject: [PATCH 1/5] Fix #4769: Use theme base text color and add underline on hover/focus for Mathesar link in forms --- .../data-forms/form-maker/DataFormBranding.svelte | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/mathesar_ui/src/systems/data-forms/form-maker/DataFormBranding.svelte b/mathesar_ui/src/systems/data-forms/form-maker/DataFormBranding.svelte index 1af77aa073..7771a5a6db 100644 --- a/mathesar_ui/src/systems/data-forms/form-maker/DataFormBranding.svelte +++ b/mathesar_ui/src/systems/data-forms/form-maker/DataFormBranding.svelte @@ -21,11 +21,18 @@ .form-branding { padding: var(--sm1); color: var(--color-fg-base-muted); + a { + color: var(--color-fg-base); text-decoration: none; - &:hover { - color: var(--color-fg-base); - border-bottom: solid 2px var(--color-brand); + transition: + color 120ms ease, + text-decoration 120ms ease; + + &:hover, + &:focus { + text-decoration: underline; + outline: none; } } } From 49aadbcf57456b96e10dd690427c37093c24b18b Mon Sep 17 00:00:00 2001 From: Ashwath Date: Mon, 24 Nov 2025 23:08:05 +0530 Subject: [PATCH 2/5] Use border-bottom for SVG-only Mathesar link underline with theme color --- .gitignore | 1 + .../form-maker/DataFormBranding.svelte | 34 ++++++++++--------- 2 files changed, 19 insertions(+), 16 deletions(-) diff --git a/.gitignore b/.gitignore index d9e3166757..542e91defc 100644 --- a/.gitignore +++ b/.gitignore @@ -181,6 +181,7 @@ Temporary Items .media/ .secrets/ docs/_build/ +msar/ ## yaml config files ## sso.yml diff --git a/mathesar_ui/src/systems/data-forms/form-maker/DataFormBranding.svelte b/mathesar_ui/src/systems/data-forms/form-maker/DataFormBranding.svelte index 7771a5a6db..7571de8f25 100644 --- a/mathesar_ui/src/systems/data-forms/form-maker/DataFormBranding.svelte +++ b/mathesar_ui/src/systems/data-forms/form-maker/DataFormBranding.svelte @@ -18,22 +18,24 @@ From e0fc08d7c233e9ca9b4204bde9b501950f77c2e9 Mon Sep 17 00:00:00 2001 From: Ashwath Date: Mon, 24 Nov 2025 23:22:17 +0530 Subject: [PATCH 3/5] ran pritter --- .../form-maker/DataFormBranding.svelte | 34 +++++++++---------- 1 file changed, 16 insertions(+), 18 deletions(-) diff --git a/mathesar_ui/src/systems/data-forms/form-maker/DataFormBranding.svelte b/mathesar_ui/src/systems/data-forms/form-maker/DataFormBranding.svelte index 7571de8f25..6ebd6c6228 100644 --- a/mathesar_ui/src/systems/data-forms/form-maker/DataFormBranding.svelte +++ b/mathesar_ui/src/systems/data-forms/form-maker/DataFormBranding.svelte @@ -18,24 +18,22 @@ From 0946912447317cb0e741338450aae2ed86697c4a Mon Sep 17 00:00:00 2001 From: Ashwath Date: Mon, 24 Nov 2025 23:29:43 +0530 Subject: [PATCH 4/5] fix unused svg --- .../data-forms/form-maker/DataFormBranding.svelte | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/mathesar_ui/src/systems/data-forms/form-maker/DataFormBranding.svelte b/mathesar_ui/src/systems/data-forms/form-maker/DataFormBranding.svelte index 6ebd6c6228..fdfcbea8c1 100644 --- a/mathesar_ui/src/systems/data-forms/form-maker/DataFormBranding.svelte +++ b/mathesar_ui/src/systems/data-forms/form-maker/DataFormBranding.svelte @@ -19,21 +19,18 @@ From 10e001b6ddbabada32d8b9d2e0af512ec5cfa18c Mon Sep 17 00:00:00 2001 From: Ashwath Date: Mon, 24 Nov 2025 23:37:25 +0530 Subject: [PATCH 5/5] ran prettier --- .../systems/data-forms/form-maker/DataFormBranding.svelte | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/mathesar_ui/src/systems/data-forms/form-maker/DataFormBranding.svelte b/mathesar_ui/src/systems/data-forms/form-maker/DataFormBranding.svelte index fdfcbea8c1..f28fb0a0bc 100644 --- a/mathesar_ui/src/systems/data-forms/form-maker/DataFormBranding.svelte +++ b/mathesar_ui/src/systems/data-forms/form-maker/DataFormBranding.svelte @@ -19,18 +19,18 @@