-
-
Notifications
You must be signed in to change notification settings - Fork 457
Fix: allow resizing multiple selected columns simultaneously (#4921) #5029
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: allow resizing multiple selected columns simultaneously (#4921) #5029
Conversation
seancolsen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to also see changes in SheetCellResizer.svelte so that all the columns resize in realtime as the user is dragging.
|
Implemented realtime multi-column resizing in SheetCellResizer.svelte as requested. |
seancolsen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is working pretty well now!
There's still a small issue that I wonder if you could try fixing...
When I stop resizing multiple columns, I notice a momentary flash where the columns go back to their original size briefly, and then return to their new size thereafter. It looks a bit janky. And it doesn't happen when resizing just one column.
|
I’ve spent some time digging into this, but I’m hitting a wall. I’ve tried a few approaches, but none led to a clean solution. Could you share how you’d approach this or point me in the right direction? I want to make sure I’m moving forward correctly. |
|
@Ahamed1846 it looks like you're part of the Kalvium student group. Could you get some help from other students in the program? Can some of you work together to figure this out? |
|
Fixed the flashing issue during multi-column resizing. |
|
@Ahamed1846 sorry, but the deeper I dug into this PR the more problems I kept finding. While your work did appear to function correctly, there were some problems with the implementation. In getting my head around those problems, I ended up doing the implementation myself via #5075. I apologize, but it would take a bit of time (that I don't have) to explain all the differences. I encourage you to look at my PR though if you're curious. |
Allow resizing multiple columns at once (#4921)
Fixes #4921
This PR enables resizing multiple fully-selected columns simultaneously, matching the behavior of spreadsheet tools like Google Sheets and LibreOffice Calc. Previously, resizing affected only the column whose handle was dragged, even when multiple columns were selected.
Technical details
Problem
Column resizing only affected the one being dragged, even if multiple columns were fully selected. Users expect spreadsheet-style behavior where selected columns resize together.
Fix
A new function
handleResize()was added inHeader.sveltethat:Behavior Changes
Files touched
mathesar_ui/src/systems/table-view/header/Header.sveltemathesar_ui/src/components/sheet/SheetCellResizer.sveltemathesar_ui/src/stores/table-data/columns.tsChecklist
Update index.md).developbranch of the repositoryvisible errors.
Developer Certificate of Origin
Developer Certificate of Origin