Skip to content

Conversation

@MahnoorAsghar
Copy link
Contributor

Auto-generate API documentation from CRDs

Fixes #2509

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign lentzi90 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 8, 2025
@tuminoid
Copy link
Member

tuminoid commented Aug 8, 2025

This is copy from IRSO's api doc generator right?

@MahnoorAsghar
Copy link
Contributor Author

@tuminoid

This is copy from IRSO's api doc generator right?

Yes, it is

@MahnoorAsghar MahnoorAsghar force-pushed the crd-doc branch 2 times, most recently from 2a53530 to fbed203 Compare August 8, 2025 15:27
@MahnoorAsghar
Copy link
Contributor Author

/retest-required

@MahnoorAsghar
Copy link
Contributor Author

/retest-required

Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The difference between this BMO PR and IRSO here is that IRSO runs the "make manifests" as part of build Github workflow (in a VM), while BMO runs make generate as a Prow job (in a container).

The correct way for BMO would be to have it in a separate Prow job, which runs the crdoc container in Prow.

"${CONTAINER_RUNTIME}" run --rm -v "${PWD}":/src:ro,z \
ghcr.io/fybrik/crdoc:"${CRDOC_VERSION}" \
--resources /src/config/base/crds/bases/ --output /dev/stdout \
> docs/api.md No newline at end of file
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing eol

@metal3-io-bot
Copy link
Contributor

@MahnoorAsghar: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
shellcheck e87422f link true /test shellcheck
generate e87422f link true /test generate
test e87422f link true /test test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@MahnoorAsghar MahnoorAsghar changed the title 🌱 Auto-generate API documentation from CRDs WIP 🌱 Auto-generate API documentation from CRDs Sep 25, 2025
@metal3-io-bot metal3-io-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Generate local API documentation from CRDs

3 participants